Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable python zoom scale in Dynamo Preferences Panel #13798

Merged
merged 16 commits into from
Mar 9, 2023

Conversation

filipeotero
Copy link
Contributor

@filipeotero filipeotero commented Mar 3, 2023

Purpose

Per https://jira.autodesk.com/browse/DYN-5531, It is included in this PR the functionality for the Python Zoom Scale setting.

22% is the default scale of python editor similar to previous states
image

Users can now manipulate zoom scale both in python editor using ctrl + scrolling or in Preferences -> Visual settings -> Zoom Scalling (see below)

PythonZoomScale

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @jesusalvino

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments

@QilongTang QilongTang added this to the 2.18.0 milestone Mar 3, 2023
@QilongTang QilongTang marked this pull request as ready for review March 8, 2023 16:32
@QilongTang QilongTang changed the title DYN-5531 python zoom scale Enable python zoom scale in Dynamo Preferences Panel Mar 8, 2023
@@ -815,7 +815,7 @@
</Image>
</StackPanel>
<StackPanel Margin="-10,5,0,0" Orientation="Horizontal" Grid.Row="2">
<Label Content="0%"
<Label Content="{x:Static p:Resources.PreferencesViewZoomScaling0Percent}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localized instead of hardcode

Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 04ba8ae into DynamoDS:master Mar 9, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
* python zoom scale

* python zoom scale preference settings

* fix old comments

* remove unused variables

* tooltip localization

* Comments

* updates

* clean up

* update

* Update Python Editor Label

* Update test

* Comments

---------

Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
* python zoom scale

* python zoom scale preference settings

* fix old comments

* remove unused variables

* tooltip localization

* Comments

* updates

* clean up

* update

* Update Python Editor Label

* Update test

* Comments

---------

Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants