-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable python zoom scale in Dynamo Preferences Panel #13798
Enable python zoom scale in Dynamo Preferences Panel #13798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple comments
@@ -815,7 +815,7 @@ | |||
</Image> | |||
</StackPanel> | |||
<StackPanel Margin="-10,5,0,0" Orientation="Horizontal" Grid.Row="2"> | |||
<Label Content="0%" | |||
<Label Content="{x:Static p:Resources.PreferencesViewZoomScaling0Percent}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localized instead of hardcode
…otero/Dynamo into DYN-5531-Python-ZoomScale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* python zoom scale * python zoom scale preference settings * fix old comments * remove unused variables * tooltip localization * Comments * updates * clean up * update * Update Python Editor Label * Update test * Comments --------- Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]>
* python zoom scale * python zoom scale preference settings * fix old comments * remove unused variables * tooltip localization * Comments * updates * clean up * update * Update Python Editor Label * Update test * Comments --------- Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]>
Purpose
Per https://jira.autodesk.com/browse/DYN-5531, It is included in this PR the functionality for the Python Zoom Scale setting.
22% is the default scale of python editor similar to previous states
Users can now manipulate zoom scale both in python editor using ctrl + scrolling or in Preferences -> Visual settings -> Zoom Scalling (see below)
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang
FYIs
@RobertGlobant20 @jesusalvino