-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Node Font Size Setting UI #13790
Conversation
Can we keep |
@Jingyi-Wen How do you feel about that? |
I did think about that. From the visual design perspective though - the toggle is only taking one line whereas the radio button for run mode takes 2 lines, so they don't really line up. |
|
I wouldn't recommend that. I think putting two unrelated items in the same line could be confusing. In a perfect world, it's better for both the |
@Jingyi-Wen @avidit Updated. PTAL |
Reported regression is sporadic and @RobertGlobant20 is working on fixing it. Merging |
* Remove Node Font Size Setting UI * switch order
* Remove Node Font Size Setting UI * switch order
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
per https://jira.autodesk.com/browse/DYN-4891, remove Node Font Size setting from Preferences Panel per customers' request. Customers intend to rely on graph zoom level instead.
Notice there is no effect on serialization because Dynamo does not serialize such a setting currently.
Before:
After:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
remove Node Font Size setting from Preferences Panel per customers' request
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of