Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust minimum percentage of the Library zoom scale #13789

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Adjust minimum percentage of the Library zoom scale #13789

merged 1 commit into from
Mar 1, 2023

Conversation

filipeotero
Copy link
Contributor

Purpose

  • Minimum value of the Zoom Scale for the Library is set to 25%
  • Added an if before setting the zoomFactor to avoid an exception

zoomScaleMinimumValue

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

@QilongTang QilongTang added this to the 2.18.0 milestone Mar 1, 2023
@QilongTang QilongTang merged commit a4b09a0 into DynamoDS:master Mar 1, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
@filipeotero @sm6srw
update zoom scale label position after initialization (DynamoDS#13789)
acefd82
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
@filipeotero @sm6srw
update zoom scale label position after initialization (#13789)
5e63304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@filipeotero @QilongTang