Edit Python Port Properties #13788
Merged
Edit Python Port Properties #13788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a new button to the OutPortContextMenu to allow users to Edit Port Properties - for the time being, it is only enabled and visible in case of Python Node Model (in future this check can be removed allowing other nodes to use this functionality as well)
- At this point, output port can be renamed - TODO: handle contextmenu - should close after interaction, now keeps alive - TODO: remove Categories - TODO: create validation checks (cannot be the same as any other Port, cannot be null, cannot be an Integer, anything else?) - TODO: Set Prompt name based on Inport/Outport usage
- since we no longer need the popup to stick around after we have launched the Edit Properties Prompt, hide the popup
- added Port Properties Prompt property values as resources - added a dynamic prompt title based on the PortType value of the port - further cleaned the UI design
- cannot find DynamoView as an owner for some reason, using WindowStartupLocation.CenterScreen instead - control cleanup
- refactor chunks of code for better usability - incorporated number and unique port name validation checks
- now works for both Input and Output ports
- will prompt the user to agree to lose changes when removing port
- changed the validation warning method to status label underneath the Name text box
- disable 'Save' button when we are in a warning state (invalid port name) - cleans up interaction around blank name
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
- added comment to public converter
- moved private property to top of class for better readability
- used DynamoUtilities.PathHelper method to check for name validation
- removed unnecessary code
- fixed page tag
reddyashish
approved these changes
Mar 14, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* Outport - added Edit Port Properties button to port context menu - added a new button to the OutPortContextMenu to allow users to Edit Port Properties - for the time being, it is only enabled and visible in case of Python Node Model (in future this check can be removed allowing other nodes to use this functionality as well) * Output rename working - At this point, output port can be renamed - TODO: handle contextmenu - should close after interaction, now keeps alive - TODO: remove Categories - TODO: create validation checks (cannot be the same as any other Port, cannot be null, cannot be an Integer, anything else?) - TODO: Set Prompt name based on Inport/Outport usage * Hide popup after interaction - since we no longer need the popup to stick around after we have launched the Edit Properties Prompt, hide the popup * Resource properties added - added Port Properties Prompt property values as resources - added a dynamic prompt title based on the PortType value of the port - further cleaned the UI design * WindowsStartupLocation - Screen - cannot find DynamoView as an owner for some reason, using WindowStartupLocation.CenterScreen instead - control cleanup * Code refactor, name validation - refactor chunks of code for better usability - incorporated number and unique port name validation checks * Added Port Properties Prompt to context menu of Input port - now works for both Input and Output ports * Added port removal notification message - will prompt the user to agree to lose changes when removing port * Validation changed to status label - changed the validation warning method to status label underneath the Name text box * Save disabled on warning - disable 'Save' button when we are in a warning state (invalid port name) - cleans up interaction around blank name * Public converter comment - added comment to public converter * Moved private property - moved private property to top of class for better readability * Used DynamoUtilities method - used DynamoUtilities.PathHelper method to check for name validation * Removed commented out code - removed unnecessary code * Added back the missing page tag - fixed page tag
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Outport - added Edit Port Properties button to port context menu - added a new button to the OutPortContextMenu to allow users to Edit Port Properties - for the time being, it is only enabled and visible in case of Python Node Model (in future this check can be removed allowing other nodes to use this functionality as well) * Output rename working - At this point, output port can be renamed - TODO: handle contextmenu - should close after interaction, now keeps alive - TODO: remove Categories - TODO: create validation checks (cannot be the same as any other Port, cannot be null, cannot be an Integer, anything else?) - TODO: Set Prompt name based on Inport/Outport usage * Hide popup after interaction - since we no longer need the popup to stick around after we have launched the Edit Properties Prompt, hide the popup * Resource properties added - added Port Properties Prompt property values as resources - added a dynamic prompt title based on the PortType value of the port - further cleaned the UI design * WindowsStartupLocation - Screen - cannot find DynamoView as an owner for some reason, using WindowStartupLocation.CenterScreen instead - control cleanup * Code refactor, name validation - refactor chunks of code for better usability - incorporated number and unique port name validation checks * Added Port Properties Prompt to context menu of Input port - now works for both Input and Output ports * Added port removal notification message - will prompt the user to agree to lose changes when removing port * Validation changed to status label - changed the validation warning method to status label underneath the Name text box * Save disabled on warning - disable 'Save' button when we are in a warning state (invalid port name) - cleans up interaction around blank name * Public converter comment - added comment to public converter * Moved private property - moved private property to top of class for better readability * Used DynamoUtilities method - used DynamoUtilities.PathHelper method to check for name validation * Removed commented out code - removed unnecessary code * Added back the missing page tag - fixed page tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to allow users to rename Python imports and outports in order to create more user-friendly and descriptive content for their custom code.
This Figma link is created for visual guidance.
Current WIP
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
WIP
Reviewers
@mjkkirschner
@Amoursol
@sm6srw
FYIs
@Jingyi-Wen