Python Node Editor Visual Update - part #3 #13783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- aligns custom highlighting rules between design script and python script editors by reusing the same method - assigned correct color values to python script keywords as per Figma (omitting the ones that are not used and shouldn't be reserved in Python, such as 'Imperative')
- changed hyperlink color for both editors
- now python script will follow the convention used in desingscript for function color
8 tasks
- aligned different pink colors to the default #F2A9F2
- changed if/else (no longer bold) - changed def/class (reuse number blue) - changed def (no longer italic)
|
I think these are the final color changes for the moment and we should be good to Merge if everything else looks OK @sm6srw ! |
reddyashish
reviewed
Mar 14, 2023
reddyashish
reviewed
Mar 14, 2023
- removed unnecessary namespace statement
- now properly marks the script as saved when using Save and Run button
QilongTang
approved these changes
Mar 14, 2023
|
Jobs on master-5 are hanged, running self-service https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1129/. |
|
DynamoCoreWpfTests.CoreUserInterfaceTests.WorkspaceContextMenu_TestIfOpenOnRightClick sporadit test failure reported. Merging. |
|
@dnenov was about to add a fix in this for the folding behavior you mentioned. May be in another PR. |
Great! Let's use another one. I would love to test this before recharge sprint |
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* Implemented CodeHighlightingRuleFactory for PythonScript - aligns custom highlighting rules between design script and python script editors by reusing the same method - assigned correct color values to python script keywords as per Figma (omitting the ones that are not used and shouldn't be reserved in Python, such as 'Imperative') * Hyperlink color - changed hyperlink color for both editors * Match function colors - now python script will follow the convention used in desingscript for function color * Update DesignScript.Resources.SyntaxHighlighting.xshd - aligned different pink colors to the default #F2A9F2 * Update ICSharpCode.PythonBinding.Resources.Python.xshd - changed if/else (no longer bold) - changed def/class (reuse number blue) - changed def (no longer italic) * Removed unnecessary namespace statement - removed unnecessary namespace statement * Fixed save on save and run - now properly marks the script as saved when using Save and Run button
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Implemented CodeHighlightingRuleFactory for PythonScript - aligns custom highlighting rules between design script and python script editors by reusing the same method - assigned correct color values to python script keywords as per Figma (omitting the ones that are not used and shouldn't be reserved in Python, such as 'Imperative') * Hyperlink color - changed hyperlink color for both editors * Match function colors - now python script will follow the convention used in desingscript for function color * Update DesignScript.Resources.SyntaxHighlighting.xshd - aligned different pink colors to the default #F2A9F2 * Update ICSharpCode.PythonBinding.Resources.Python.xshd - changed if/else (no longer bold) - changed def/class (reuse number blue) - changed def (no longer italic) * Removed unnecessary namespace statement - removed unnecessary namespace statement * Fixed save on save and run - now properly marks the script as saved when using Save and Run button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A continuation of Part 1 and Part 2. This PR only deals with the reserved words colors, aligning the color scheme used in design script editor and the python editor.
Color scheme as per Figma project
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@sm6srw
@Amoursol
FYIs
@Jingyi-Wen