DYN-5605 Dynamo installs, but fails to pick up package #13770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Feb 23, 2023
|
|
||
| PythonServices.PythonEngineManager.Instance. | ||
| LoadPythonEngine(package.LoadedAssemblies.Select(x => x.Assembly)); | ||
|
|
||
| PackgeLoaded?.Invoke(package); |
There was a problem hiding this comment.
What would be the difference here to execute this slightly later?
There was a problem hiding this comment.
There is a piece of code in the WorkspaceDepedencyView that checks the loaded python packages.
The code was interpreting some packages as missing because, when it was hitting there, they were not included in the loaded assemblies. So, we need to trigger the PackgeLoaded action after the assembly is found in the available engines.
QilongTang
approved these changes
Feb 23, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes the bug that doesn't refresh the status of some packages after being loaded.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @jesusalvino