-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling ShortcutBar items #13761
Enabling ShortcutBar items #13761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comment
Why do we still have a cut-out for them if they are disabled? Can we remove the cut-out? @QilongTang |
Agree, and also we do not have to disable the notification center at the startup page.. |
The Buttons behavior based on the scenarios are in the task @Jingyi-Wen per our discussion, Could you validate if the scope of this task is included in the 4180 please ? otherwise let us know if there is something to catch up thanks. |
@jesusalvino Yes, this seemed to be included in https://jira.autodesk.com/browse/DYN-4180 since that task includes all the menu items that needed to be disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple comments
This reverts commit 39fd836.
* Enabling ShortcutBar items * Renaming property * Using Event instead of set property * Increasing scope and refactoring * Update properties scope
This reverts commit 39fd836.
* Enabling ShortcutBar items * Renaming property * Using Event instead of set property * Increasing scope and refactoring * Update properties scope
Purpose
Improvement based on the task https://jira.autodesk.com/browse/DYN-5404
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero