Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling ShortcutBar items #13761

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Enabling ShortcutBar items #13761

merged 5 commits into from
Feb 28, 2023

Conversation

jesusalvino
Copy link
Contributor

Purpose

Improvement based on the task https://jira.autodesk.com/browse/DYN-5404

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @filipeotero

@jesusalvino
Copy link
Contributor Author

shortcutbar_enable

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment

@zeusongit
Copy link
Contributor

Why do we still have a cut-out for them if they are disabled? Can we remove the cut-out? @QilongTang

@QilongTang
Copy link
Contributor

Why do we still have a cut-out for them if they are disabled? Can we remove the cut-out? @QilongTang

Agree, and also we do not have to disable the notification center at the startup page..

@QilongTang QilongTang added this to the 2.18.0 milestone Feb 21, 2023
@jesusalvino
Copy link
Contributor Author

jesusalvino commented Feb 24, 2023

The Buttons behavior based on the scenarios are in the task

@Jingyi-Wen per our discussion, Could you validate if the scope of this task is included in the 4180 please ? otherwise let us know if there is something to catch up thanks.

shortcutbar_enable_3

@Jingyi-Wen
Copy link

@jesusalvino Yes, this seemed to be included in https://jira.autodesk.com/browse/DYN-4180 since that task includes all the menu items that needed to be disabled.

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments

@QilongTang QilongTang merged commit 39fd836 into DynamoDS:master Feb 28, 2023
QilongTang added a commit that referenced this pull request Feb 28, 2023
QilongTang added a commit that referenced this pull request Feb 28, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
* Enabling ShortcutBar items

* Renaming property

* Using Event instead of set property

* Increasing scope and refactoring

* Update properties scope
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
* Enabling ShortcutBar items

* Renaming property

* Using Event instead of set property

* Increasing scope and refactoring

* Update properties scope
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants