Update to Live Charts description and detail description #13747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added Live Charts to Dynamo UI Nodes - this is the first commit for this PR
- created a resource dictionary for custom default charts theme
- added supporting files for Dynamo Dictionary (icons, dyn example files, image example files, markdown (markdowns are 'empty', to be detailed by UX team) - changed namespace for Live Chart nodes
- renamed help files to match node full (type) names
- testing AstFarctory.BuildFunctionCall when method is in another assembly - added Helper class to provide Colors from the LiveCharts xaml dictionary - rework of BarChartNodeModel to allow for a non-nested value/input
- moved helper functions to the DynamoCore assembly to satisfy AstFactory conditions - BarChart now works with both List<double> and List<List<double>>
- added LiveCharts to Dynamo license files
- updated all the rest of the functions (besides the BarChart) - all charts now work with/without Color input - fixed old/wrong example dyn files
- multiple small visual updates
- added 26 default colors to cycle through, if the user is not providing custom colors
- changed visual style of the resizing thumb for the chart controls - added tooltip - tooltip text added to resources
…iveChartImplementation"" This reverts commit cc95adf.
…iveChartImplementation"" This reverts commit ce8acae.
- added the nodes to the library - added icons to nodes - added Alert message when default Colors are provided
- as discussed, undid the <UseWPF>true</UseWPF> setting
- swapped localization strings with resources
- the icon used for resizing the node UI window now consistent with other UI nodes, such as Watch, Watch3D
- added basic creation tests for LiveCharts - threading issues does not allow output to be tested
- changed the notification text when user provides no colors or mismatching color structure
- added dispose methods to LiveChart View and ViewModel classes - reverted small change previously made with no relevance to this PR
- removed old backup file - changed Dispose (not being triggered) to Unload to dispose of eventhandlers - cleaned up old TODO remarks
- updated detailed description text for Live Chart help files - small update to description text for consistency purposes
|
Wonderful, I was going to let you know about this when trying these new nodes! 👍🏻 |
QilongTang
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A small update to Live Chart help files and in particular to the description and detailed description.
### DeclarationsCheck these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@sm6srw
@Amoursol
FYIs
@hwahlstrom