-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Modules #13728
Python Modules #13728
Conversation
- tests - dlls
- added python modules back to the license file after merge issue
- added back a missing closing tag to DSCPython.csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all files that lives in node_modules
directories from the PR and delete these files locally. These are leftovers from a recent change where we started to use npm pack
instead of npm install
. Same goes for any package.json
and package-lock.json
files.
In |
- removed package-lock.json and package.json as instructed
It looks like the ones left are in src/Notifications/node_modules. About 100 files that should be removed from this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also looks like the wrong version of Python.Module.IfcOpenShell.dll
is included. Should be 2.5.2.7185
but is `2.5.2.7126'.
- updated dll files
The tests are still failing consistently in the pipeline. I can reproduce sporadically locally. Something is still unstable and needs a closer look (something I will do when I am back again next week). |
- removed 2 modules that are not going to be used at this moment from the license.txt (already removed from License.rtf)
@dnenov can we please remove the "IfcOpenShell" module from this PR? Unfortunately due to the LGPL/GPL license on it we are unable to ship it with Dynamo 😢 |
Ah, that's unfortunate .. . Of course, I will do it! Would it be possible to wait for @sm6srw 's input, as we dedicated a new assembly for this particular module, because of its size? We have to roll back a few things to get it out of the frame. I am mostly certain of the course we will take, but would like to run it by him if that's OK. |
- IfcOpenShell not being used due to license type - updated with the correct .dll from the updated pythnonet - removed IfcOpenShell test
- any leftover code from the implementation of IfcOpenShell module has been removed
* Python Modules Tests added - tests - dlls * Upstream Master Merge * Update to License.rtf - added python modules back to the license file after merge issue * Missing closing tag added back - added back a missing closing tag to DSCPython.csproj * Removed package-lock.json and package.json - removed package-lock.json and package.json as instructed * Further removed files * Update pythonnet - updated dll files * Removed unused modules from license.txt - removed 2 modules that are not going to be used at this moment from the license.txt (already removed from License.rtf) * IfcOpenShell removed due to license issues - IfcOpenShell not being used due to license type - updated with the correct .dll from the updated pythnonet - removed IfcOpenShell test * Removed any IfcOpenShell-related code - any leftover code from the implementation of IfcOpenShell module has been removed
This reverts commit 1a7f031.
Purpose
This PR complements an update to pythonnet. The update includes a number of useful Python modules now available to the end user straight from Dynamo. The initial list of modules is as follows:
- openifcshellIfcOpenShell was removed due to issues with the licensing typeThis PR added the updated pythonnet .dll library files:
- Python.Module.IfcOpenShellThe documentation of pythonnet README file has been updated to include the steps taken to add new modules. A dedicated test is provided for each module, asserting that it is functional. An initial environment manual test has been run with
python-3.9.12-embed-amd64
deleted asserting that Dynamo will correctly create the necessary infrastructure to run Python Scripts and the newly added modules.Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
This PR contains the following elements to complement pythonnet update.
Reviewers
@sm6srw
FYIs
@Amoursol