Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libg #13720

Merged

Conversation

aparajit-pratap
Copy link
Contributor

Purpose

Update LibG for the following updates:

  • Fix regression with Curve.SplitByPoints and Curve.SplitByParameter for PolyCurve

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Fix regression with Curve.SplitByPoints and Curve.SplitByParameter for PolyCurve

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner
Copy link
Member

I think there are some changes from master that should not be in this branch related to .net6

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove master changes

@aparajit-pratap
Copy link
Contributor Author

Ugh, I cherry-picked the changes from master. Not sure how this happened, but I'll redo this. Thanks for catching it.

@aparajit-pratap
Copy link
Contributor Author

@mjkkirschner this now looks just the same as the PR in master. Merging.

@aparajit-pratap aparajit-pratap merged commit 683f2b6 into DynamoDS:RC2.17.1_master Feb 2, 2023
@aparajit-pratap aparajit-pratap deleted the updatelibg-2.17.1 branch February 2, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants