Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert Changes #13705

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Insert Changes #13705

merged 1 commit into from
Jan 31, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jan 24, 2023

Purpose

A small PR addressing some outstanding resource issues to Insert functionality. Addresses this jira task. Changes toast notification behavior from user interactive to passively disappears on mouseclick.

behavior after changes

insert_changes

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • added Insert dialog box title to resources, changed the text
  • added insert run mode change notification to resources
  • change the Toast type (now disappears on the next mouseclick)
  • change the order in which Insert is done and the mode is changed, i.e. mode would change only if a graph has been inserted

Reviewers

@sm6srw

FYIs

@Amoursol

@dnenov
Insert Changes
b02923e 
- added Insert dialog box title to resources, changed the text
- added insert run mode change notification to resources
- change the Toast type (now disappears on the next mouseclick)
- change the order in which Insert is done and the mode is changed, i.e. mode would change only if a graph has been inserted
@Amoursol
Copy link
Contributor

@dnenov generally looks great. But I would switch the word "definition" inside "Insert Dynamo definition..." to "graph" as the term definition is more typically used for .DYF's (Custom nodes) and could be confusing to users.

sm6srw
sm6srw approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@sm6srw sm6srw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing Sols comment and passing tests.

@sm6srw sm6srw marked this pull request as ready for review January 26, 2023 20:19
@sm6srw
Copy link
Contributor

sm6srw commented Jan 31, 2023 •
edited
Loading

Tests passing here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8286/

@sm6srw sm6srw merged commit ce73889 into DynamoDS:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzart90 pinzart90 pinzart90 approved these changes

@sm6srw sm6srw sm6srw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnenov @Amoursol @sm6srw @pinzart90