-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross platform part2 #13662
Cross platform part2 #13662
Conversation
…namo into cross_platform_part2
@@ -0,0 +1 @@ | |||
These assemblies are built from https://git.autodesk.com/Dynamo/pythonnet targeting netstandard2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added new assemblies for netstd20 only because I could not get tests to run on the pythonnet targeting netstd20
Once we get pythonnet CICD to run properly, we can just keep the new netstd20 assmeblies (since they are compatible with net48 and net6.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the test run properly for you locally? The embedded test part of CICD for PythoNet is unstable (when running in docker) and has been for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we have more changes coming into python net soon so we should resolve this sooner than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get the tests to run locally.
Something with the nunit version is causing issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR does:
Added remaining projects to the dotnet6 build
Added new Pythonnet assemblies targeting netstandard2.0 (will remove when pythonnet PR is merged)
Fixed a bug with the way we search for ASM files on linux vs windows
Some small changes from @saintentropy