Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyn 5488 add horizontal scroll bar #13661

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Dyn 5488 add horizontal scroll bar #13661

merged 3 commits into from
Jan 6, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Showing horizontal scrollbar in DataGrid when the size of the grid exceeds the sidebar width.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Showing horizontal scrollbar in DataGrid when the size of the grid exceeds the sidebar width.

Reviewers

@QilongTang

FYIs

When showing the documentation for packages the PackageDetailView extension was not showing the horizontal scroll bar then I added a change so that will be shown when the content is bigger than the usual width.
The HorizontalScrollBar will be shown only in the DataGrid due that if is shown in the complete SideBar is showing a weird white box.
@RobertGlobant20
Copy link
Contributor Author

GIF showing the scrollbar in the DataGrid of the Package Details.
PackageDetailsScrollBar

@QilongTang QilongTang merged commit 3895606 into DynamoDS:master Jan 6, 2023
@QilongTang QilongTang deleted the DYN-5488-Add-Horizontal-ScrollBar branch January 6, 2023 08:58
QilongTang pushed a commit that referenced this pull request Jan 12, 2023
* Removing CanToggleLoginState (#13657)

* Dyn 5488 add horizontal scroll bar (#13661)

* DYN-5488-Add-Horizontal-Scrollbar

When showing the documentation for packages the PackageDetailView extension was not showing the horizontal scroll bar then I added a change so that will be shown when the content is bigger than the usual width.

* DYN-5488-Add-Horizontal-Scrollbar

The HorizontalScrollBar will be shown only in the DataGrid due that if is shown in the complete SideBar is showing a weird white box.

* Disable loading extensions and view extensions in service mode.

Co-authored-by: filipeotero <[email protected]>
Co-authored-by: Roberto T <[email protected]>
QilongTang added a commit that referenced this pull request Feb 16, 2023
* Service Mode Initial commit

* clean up

* Update

* Diable SearchModel in Service Mode

* add console output

* [DNM] DAAS draft  (#13677)

* Removing CanToggleLoginState (#13657)

* Dyn 5488 add horizontal scroll bar (#13661)

* DYN-5488-Add-Horizontal-Scrollbar

When showing the documentation for packages the PackageDetailView extension was not showing the horizontal scroll bar then I added a change so that will be shown when the content is bigger than the usual width.

* DYN-5488-Add-Horizontal-Scrollbar

The HorizontalScrollBar will be shown only in the DataGrid due that if is shown in the complete SideBar is showing a weird white box.

* Disable loading extensions and view extensions in service mode.

Co-authored-by: filipeotero <[email protected]>
Co-authored-by: Roberto T <[email protected]>

* Clean up

* Clean up and skip more steps

* clean up

* clean up

* clean up

* clean up

* Fix Unit tests

* Clean up

* Unit tests

* unit tests

* Fix Unit tests

* Comments

* Service mode changes (#13739)

* Add ServiceMode to Linux

* Load extensions in service mode

* Do not load preference setting file in ServiceMode

---------

Co-authored-by: Craig Long <[email protected]>

---------

Co-authored-by: reddyashish <[email protected]>
Co-authored-by: filipeotero <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Craig Long <[email protected]>
Co-authored-by: Craig Long <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants