DYN-4964-WorkingRange-Popup #13656

RobertGlobant20 · 2023-01-04T19:14:35Z

Purpose

Adding extra functionality for Working Range in Dynamo workspace
I've added a new button in the Workspace that when is clicked will show a popup containing the working ranges and the one currently selected. This new button will show a different image when the mouse is hover and when is clicked, also I've added a tooltip. For implementing this functionality I've added a new Popup (GeometryScalingPopup.xaml) and it's corresponding ViewModel. Finally I've added a converter that will receive as a parameter the current Working Range and will return a Brush with a specific color so the checkmark will be visible or not.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Release Notes

Adding extra functionality for Working Range in Dynamo workspace

Reviewers

@QilongTang

FYIs

@Jingyi-Wen

I've added a new button in the Workspace that when is clicked will show a popup containing the working ranges and the one currently selected. This new button will show a different image when the mouse is hover and when is clicked, also I've added a tooltip. For implementing this functionality I've added a new Popup (GeometryScalingPopup.xaml) and it's corresponding ViewModel. Finally I've added a converter that will receive as a parameter the current Working Range and will return a Brush with a specific color so the checkmark will be visible or not.

RobertGlobant20 · 2023-01-04T19:16:10Z

GIF showing the Working Range functionality in the Dynamo Workspace.

QilongTang · 2023-01-09T16:07:57Z

hi @RobertGlobant20 My understanding is that the geometry scaling setting in preferences is more like the default setting for new workspace, it is not meant to be in sync with the current setting in homeworkspace. Did I missing anything? FYI: @Jingyi-Wen

RobertGlobant20 · 2023-01-09T17:04:43Z

hi @RobertGlobant20 My understanding is that the geometry scaling setting in preferences is more like the default setting for new workspace, it is not meant to be in sync with the current setting in homeworkspace. Did I missing anything? FYI: @Jingyi-Wen

@QilongTang then by reading again the AC in the task the GeometryScaling Popup should be read-only, right?
I mean, For example, if you set by default the GeometryScaling = Medium, then in the Workpace the Popup will only show Medium selected without the possibility to change it.

mjkkirschner · 2023-01-09T17:08:26Z

I don't think this is correct. Users need to be able to set the workspace scaling for a workspace, not just read it.

Are these actually two different preferences?
New Workspace Default Scaling?
Workspace Current Scaling?

QilongTang · 2023-01-10T06:53:05Z

I don't think this is correct. Users need to be able to set the workspace scaling for a workspace, not just read it.

Are these actually two different preferences? New Workspace Default Scaling? Workspace Current Scaling?

Yes, they are. The current UX before this change is just confusing. I believe the current geometry scaling in the preference panel is acting as the current workspace scaling setting reflection, but almost all of the other settings in preferences are Dynamo-specific instead of workspace specific. That's why we started this task of enabling a new UI to distinguish both.

Jingyi-Wen · 2023-01-10T14:02:51Z

I don't think this is correct. Users need to be able to set the workspace scaling for a workspace, not just read it.
Are these actually two different preferences? New Workspace Default Scaling? Workspace Current Scaling?

Yes, they are. The current UX is just confusing. I believe the current one in the preference panel is acting as current scaling setting, but almost all of the settings in preferences are Dynamo specific instead of workspace specific. That's why we started this task of enable a new UI to distinguish both.

Hi @QilongTang I'm a bit confused why these have to be 2 separate preferences. Could you please elaborate more?

QilongTang · 2023-01-10T16:01:06Z

I don't think this is correct. Users need to be able to set the workspace scaling for a workspace, not just read it.
Are these actually two different preferences? New Workspace Default Scaling? Workspace Current Scaling?

Yes, they are. The current UX is just confusing. I believe the current one in the preference panel is acting as current scaling setting, but almost all of the settings in preferences are Dynamo specific instead of workspace specific. That's why we started this task of enable a new UI to distinguish both.

Hi @QilongTang I'm a bit confused why these have to be 2 separate preferences. Could you please elaborate more?

See my comments above. I would think of this problem as similar to the group styles user experience. There are defaults styles that would apply only when users choose to, otherwise they are purely settings that does not affect current workspace. There are in-workspace styles that apply to the current workspace only, once the current workspace is saved and closed, they are gone and not necessarily related to the next new workspace.

Jingyi-Wen · 2023-01-10T16:09:19Z

I don't think this is correct. Users need to be able to set the workspace scaling for a workspace, not just read it.
Are these actually two different preferences? New Workspace Default Scaling? Workspace Current Scaling?

Yes, they are. The current UX is just confusing. I believe the current one in the preference panel is acting as current scaling setting, but almost all of the settings in preferences are Dynamo specific instead of workspace specific. That's why we started this task of enable a new UI to distinguish both.

Hi @QilongTang I'm a bit confused why these have to be 2 separate preferences. Could you please elaborate more?

See my comments above. I would think of this problem as similar to the group styles user experience. There are defaults styles that would apply only when users choose to, otherwise they are purely settings that does not affect current workspace. There are in-workspace styles that apply to the current workspace only, once the current workspace is saved and closed, they are gone and not necessarily related to the next new workspace.

I see. Then I think we can rename the one on canvas to "Workspace Geometry Scaling" and the Preferences Panel one "Default Geometry Scaling". Behavior-wise, changing the workspace one won't sync with the Preferences.
We should also consider adding more detailed tooltips for both.

QilongTang · 2023-01-10T16:28:08Z

@Jingyi-Wen I agree. @RobertGlobant20 Let me know if you feel the direction is proper, I think after the renaming, we will need to introduce the Default Geometry Scaling as a new setting in Preferences if there is no such (if I remember correctly). But the changes should be not too expensive

RobertGlobant20 · 2023-01-10T22:12:45Z

@Jingyi-Wen I agree. @RobertGlobant20 Let me know if you feel the direction is proper, I think after the renaming, we will need to introduce the Default Geometry Scaling as a new setting in Preferences if there is no such (if I remember correctly). But the changes should be not too expensive

@QilongTang then in my understanding the new setting (Property) that will be added in Preferences (Default Geometry Scaling) will be set only in the Preferences panel (General tab) and the dynViewModel.PreferencesViewModel.ScaleSize property will be set in the new popup shown in Workspace (both properties won't be sync but by default when a new workspace is created it will have the default Geometry Scaling value selected).
If I remember correctly PreferencesViewModel.ScaleSize is being serialized in the dyn file as ScaleFactor, what about the new added PreferencesViewModel.DefaultGeometryScaling, will be serialized?. Thanks

QilongTang · 2023-01-11T11:10:22Z

HI @RobertGlobant20
then in my understanding the new setting (Property) that will be added in Preferences (Default Geometry Scaling) will be set only in the Preferences panel (General tab)
Yes

and the dynViewModel.PreferencesViewModel.ScaleSize property will be set in the new popup shown in Workspace (both properties won't be sync but by default when a new workspace is created it will have the default Geometry Scaling value selected) from preference panel
Yes

If I remember correctly PreferencesViewModel.ScaleSize is being serialized in the dyn file as ScaleFactor, what about the new added PreferencesViewModel.DefaultGeometryScaling, will be serialized? Thanks
This is something I would like to discuss with you. The setting will be serialized, and our team have plenty examples adding a new setting into the preference. If you would like to split it out in a new PR, that is also fine. For the old property, we can keep it as it is and manage it in a lazy way, unless you feel we have the need to obsolete it (and use a new one) now

RobertGlobant20 · 2023-01-11T19:55:16Z

HI @RobertGlobant20 then in my understanding the new setting (Property) that will be added in Preferences (Default Geometry Scaling) will be set only in the Preferences panel (General tab) Yes

and the dynViewModel.PreferencesViewModel.ScaleSize property will be set in the new popup shown in Workspace (both properties won't be sync but by default when a new workspace is created it will have the default Geometry Scaling value selected) from preference panel Yes

If I remember correctly PreferencesViewModel.ScaleSize is being serialized in the dyn file as ScaleFactor, what about the new added PreferencesViewModel.DefaultGeometryScaling, will be serialized? Thanks This is something I would like to discuss with you. The setting will be serialized, and our team have plenty examples adding a new setting into the preference. If you would like to split it out in a new PR, that is also fine. For the old property, we can keep it as it is and manage it in a lazy way, unless you feel we have the need to obsolete it (and use a new one) now

@QilongTang Just for start the discussion about it: when checking the code for adding the DefaultGeometryScaling property and making the code in the Preferences to use this new property I realized that there are more edge cases that I didn't consider, for example I can see that the RadioButtons are not directly binded to the PreferencesViewModel.ScaleSize (when the radiobutton is changed the PreferencesView.scaleValue is updated and later DynamoViewModel.ScaleFactorLog is updated with scaleValue when the Preferences is closed ) and also that after changing the Geometry Scale value and closing the Preferences panel the graph is run and is serialized until the Save button in Dynamo is pressed.

Just to be in the same page I've created a list of requirements, let me know if all of them makes sense to you.

If the user clicks a different default value (RadioButton) in the Preferences panel (tab General->Geometry Scaling), the current graph geometry scaling won't be affected and the graph won't be run (currently after closing the Preferences panel the graph is being executed with the new values when RunMode = Automatic).
Considering the case that the default value for GeometryScaling in Preferences panel (tab General -> Geometry Scaling) is Large, if a new workspace is created then if the user opens the new Geometry Scaling popup, it will show the Large value selected.
Following the previous example if the user clicks the new GeometryScaling control in workspace and in the popup selects GeometryScaling = Small then the Default value in Preferences panel won't change (remain Large) but in this case the Graph will be updated with the new Geometry Scaling value and automatically run (RunMode = Automatic).
When the user changes the GeometryScaling value using the new workspace control then the graph will be marked as dirty expecting the user to save the graph but the graph will be run with the new Geometry Scale value.
The workspace Geometry Scale value will be serialized in the dyn file as ScaleFactor until the user press the Dynamo Save button (right now this is how is working).
The default Geometry Scaling value will be serialized in the DynamoSettings.xml file as DefaultScaleFactor until Dynamo is closed (not sure if the graph should be marked as dirty or not).
When the user changes the GeometryScaling value using the new workspace control and RunMode = Automatic then the graph will be run with the new value and it will show the message below (as currently is happening).

QilongTang · 2023-01-12T16:04:20Z

Hi @RobertGlobant20

If the user clicks a different default value (RadioButton) in the Preferences panel (tab General->Geometry Scaling), the current graph geometry scaling won't be affected and the graph won't be run (currently after closing the Preferences panel the graph is being executed with the new values when RunMode = Automatic).
Yes
Considering the case that the default value for GeometryScaling in Preferences panel (tab General -> Geometry Scaling) is Large, if a new workspace is created then if the user opens the new Geometry Scaling popup, it will show the Large value selected.
Yes
Following the previous example if the user clicks the new GeometryScaling control in workspace and in the popup selects GeometryScaling = Small then the Default value in Preferences panel won't change (remain Large) but in this case the Graph will be updated with the new Geometry Scaling value and automatically run (RunMode = Automatic).
Yes
When the user changes the GeometryScaling value using the new workspace control then the graph will be marked as dirty expecting the user to save the graph but the graph will be run with the new Geometry Scale value.
Yes
The workspace Geometry Scale value will be serialized in the dyn file as ScaleFactor until the user press the Dynamo Save button (right now this is how is working).
Yes
The default Geometry Scaling value will be serialized in the DynamoSettings.xml file as DefaultScaleFactor until Dynamo is closed (regardless if the graph should be marked as dirty or not).
Yes
When the user changes the GeometryScaling value using the new workspace control and RunMode = Automatic then the graph will be run with the new value and it will show the message below (as currently is happening).
Yes

Added functionality for the new DefaultGeometryScaling property that will be serialized in the DynamoSettings.xml. Also I've disconnected the functionality of selecting the Geometry Scale for the current Workspace in the Preferences panel, now will be selected from the Dynamo workspace and will be serialized in the dyn file (as currently is happening).

RobertGlobant20 · 2023-01-16T23:48:32Z

Hi @RobertGlobant20

If the user clicks a different default value (RadioButton) in the Preferences panel (tab General->Geometry Scaling), the current graph geometry scaling won't be affected and the graph won't be run (currently after closing the Preferences panel the graph is being executed with the new values when RunMode = Automatic).
Yes

Considering the case that the default value for GeometryScaling in Preferences panel (tab General -> Geometry Scaling) is Large, if a new workspace is created then if the user opens the new Geometry Scaling popup, it will show the Large value selected.
Yes

Following the previous example if the user clicks the new GeometryScaling control in workspace and in the popup selects GeometryScaling = Small then the Default value in Preferences panel won't change (remain Large) but in this case the Graph will be updated with the new Geometry Scaling value and automatically run (RunMode = Automatic).
Yes

When the user changes the GeometryScaling value using the new workspace control then the graph will be marked as dirty expecting the user to save the graph but the graph will be run with the new Geometry Scale value.
Yes

The workspace Geometry Scale value will be serialized in the dyn file as ScaleFactor until the user press the Dynamo Save button (right now this is how is working).
Yes

The default Geometry Scaling value will be serialized in the DynamoSettings.xml file as DefaultScaleFactor until Dynamo is closed (regardless if the graph should be marked as dirty or not).
Yes

When the user changes the GeometryScaling value using the new workspace control and RunMode = Automatic then the graph will be run with the new value and it will show the message below (as currently is happening).
Yes

@QilongTang I've done several changes for achieving the previous requirements, please review the commit: a2a3a1c

RobertGlobant20 · 2023-01-16T23:49:33Z

GIF showing the behavior of the Default Geometry Scale.

RobertGlobant20 · 2023-01-16T23:50:28Z

GIF showing the behavior of the Workspace Geometry Scale.

Jingyi-Wen · 2023-01-17T13:51:45Z

Shall we rename the one on canvas to "Workspace Geometry Scaling" and the Preferences Panel one "Default Geometry Scaling"?

RobertGlobant20 · 2023-01-17T15:51:08Z

Shall we rename the one on canvas to "Workspace Geometry Scaling" and the Preferences Panel one "Default Geometry Scaling"?

@Jingyi-Wen

Then this should be the change for Preferences panel, right?

And for the workspace, are you talking just about the tooltip?

Jingyi-Wen · 2023-01-17T17:04:42Z

Shall we rename the one on canvas to "Workspace Geometry Scaling" and the Preferences Panel one "Default Geometry Scaling"?

@Jingyi-Wen

Then this should be the change for Preferences panel, right?

And for the workspace, are you talking just about the tooltip?

Correct. Thanks!

Updated the string shown in Preferences panel (Geometry Scaling section) and the tooltip showed when the mouse is over the new Workspace button.

When merging master to my branch there were some changed that I didn't noticed in the PR so I'm reverting back those changes.

src/DynamoCore/Configuration/PreferenceSettings.cs

src/DynamoCoreWpf/ViewModels/Core/GeometryScalingViewModel.cs

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs

src/DynamoCoreWpf/ViewModels/Core/GeometryScalingViewModel.cs

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

src/DynamoCoreWpf/Views/Core/GeometryScalingPopup.xaml.cs

Fixed several comments also several methods were removed (like RadioGeometryScaling_Checked method) or moved The property GeoScalingViewModel was moved from DynamoViewModel to WorkspaceViewModel.. The property CurrentGeometryScaling was deleted due that was duplicating a functionality.

aparajit-pratap · 2023-01-20T21:05:50Z

GIF showing the behavior of the Workspace Geometry Scale.

@RobertGlobant20 is the graph re-executing once you change the workspace geometry scale setting? I would expect it to but from this gif, it doesn't look like it is. At least the message near the Run button doesn't update saying it has run with the new working range.

aparajit-pratap · 2023-01-20T21:11:03Z

Just so I understand correctly, the purpose of the default geometry scale setting is that when creating a new workspace, this value can be assigned to the workspace-specific setting, to begin with, and from that point onwards, whatever setting that's picked for the workspace setting, it will override the default setting for that workspace, is that correct?
If this is true, @RobertGlobant20 please make sure that only the workspace setting is propagated to LibG (the first time and for every subsequent change) and make sure the default setting is only used to copy its value to the workspace setting for a newly created workspace the first time. Also, the whole graph should be rerun every time the workspace setting is changed.

When changing the Workspace Geometry Scaling it was not running the graph so I did some changes so it will be running the graph every time is updated.

RobertGlobant20 · 2023-01-20T23:39:29Z

@RobertGlobant20 is the graph re-executing once you change the workspace geometry scale setting? I would expect it to but from this gif, it doesn't look like it is. At least the message near the Run button doesn't update saying it has run with the new working range.

@aparajit-pratap I just noticed that problem, I've applied a fix for that. Here is a GIF updated.
Fix: 8f5ba85

RobertGlobant20 · 2023-01-20T23:54:24Z

Just so I understand correctly, the purpose of the default geometry scale setting is that when creating a new workspace, this value can be assigned to the workspace-specific setting, to begin with, and from that point onwards, whatever setting that's picked for the workspace setting, it will override the default setting for that workspace, is that correct? If this is true, @RobertGlobant20 please make sure that only the workspace setting is propagated to LibG (the first time and for every subsequent change) and make sure the default setting is only used to copy its value to the workspace setting for a newly created workspace the first time. Also, the whole graph should be rerun every time the workspace setting is changed.

@aparajit-pratap The Default Geometry Scale value (a property in PreferencesViewModel) will be just a reference as you said that when we create a new Workspace this value will be assigned to Workspace Geometry Scale (a property in GeometryScalingViewModel), then when we set the Workspace Geometry Scale the graph is automatically re-run and if we save the graph we will be saving in the dyn file the Workspace Geometry Scale value (ScaleFactor in the dyn file).
Then the next sentences are true:

When we close Dynamo the Default Geometry Scale value will be written in DynamoSettings.xml.
When we load Dynamo the DefaultScaleFactor field will be read from DynamoSettings.xml and set Default Geometry Scale value.
When we edit the Default Geometry Scale from Preferences panel and close Dynamo, the updated value will be written to DynamoSettings.xml.
When we load an exiting dyn file the ScaleFactor field will be read and with that value set to Workspace Geometry Scale.
If we load an existing dyn file and edit the Workspace Geometry Scale after pressing save the value will be updated in dyn file.
I hope I clarified your question otherwise we can have a call for more detailed explanation.
Thanks

QilongTang · 2023-01-21T04:53:18Z

src/DynamoCoreWpf/Views/Core/GeometryScalingPopup.xaml.cs

+        /// This event is generated every time the user clicks a Radio Button in the Geometry Scaling section
+        /// The method just get the Radio Button clicked and saves the ScaleValue selected
+        /// This are the values used for the scales:
+        /// - 2 - Small


Well I think this is still 1 - Small right?

Well, this comment is trying to give information to developer related to which value could contain the scaleFactor variable, if you see to the ConvertUIToScaleFactor() method is using a formula so that if we pass the 0 index from UI (the first button - small) then the formula returns -2 and that's the value stored in ScaleValue.

This is a table of the values, I hope this make it more clear.

QilongTang · 2023-01-21T04:56:57Z

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

                var t = new DelegateBasedAsyncTask(model.Scheduler, () => model.ResetEngine());
                model.Scheduler.ScheduleForExecution(t);

                ShowStartPage = false; // Hide start page if there's one.
+
+                var defaultWorkspace = Workspaces.FirstOrDefault();


Could this be custom node workspace if user opened dyf first? I thought there are pointer already

this code was also added in the part in which the user creates a new custom node, check the next commit:
c209794

QilongTang · 2023-01-21T04:59:05Z

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

@@ -2563,6 +2575,11 @@ internal bool ClearHomeWorkspaceInternal()

                model.ClearCurrentWorkspace();

+                var defaultWorkspace = Workspaces.FirstOrDefault();
+                //Every time that a new workspace is created we have to assign the Defautl Geometry Scaling value defined in Preferences (comming from DynamoSettings.xml)


It seems we can remove (comming from DynamoSettings.xml)? If user, just modified the setting, then the setting is not serialized yet, as long as we mentioned Defautl Geometry Scaling value defined in Preferences, it should be fine

Fixed comment in the next commit:
c209794

QilongTang · 2023-01-21T05:14:09Z

src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs

+                GeoScalingPopup = new GeometryScalingPopup(ViewModel.DynamoViewModel);
+
+            GeoScalingPopup.Placement = PlacementMode.Bottom;
+            GeoScalingPopup.PlacementTarget = geometryScalingButton;


Do we need to set the placement everytime or can we set only once at initialization?

I've moved this piece of code inside the if statemente below so it will be executed one time, check the next commit:
c209794

QilongTang · 2023-01-21T05:17:21Z

src/DynamoCoreWpf/Views/Core/GeometryScalingPopup.xaml.cs

+        {
+            var selectedButton = sender as Button;
+            if (selectedButton == null) return;
+            //var buttons = BaseGrid.Children.OfType<Button>();


if not needed, let's delete it

deleted in the next commit: c209794

QilongTang

LGTM with some comments, any chance you can add unit test for the new setting serialization/deserialization?

Add functionality for when a custom node is created the Workspace Scale Factor is set. Updating and removing some comments and also I started to add the unit test.

Updating Unit Test

RobertGlobant20 · 2023-01-24T23:41:11Z

LGTM with some comments, any chance you can add unit test for the new setting serialization/deserialization?

Added a unit test for checking serialization/deserialization, please check the next commit: bcf9a45

I did the next fixes: The test TestImportCopySettings() was failing due that was reading the DynamoSettings-NewSettings.xml and comparing against the properties in PreferencesSetting so the DefaultScaleFactor was missing in the DynamoSettings-NewSettings.xml file. The test PreferencesGeoScaling_RunGraph_Automatic due that was opening the Preferences panel and changing the Geometry Scaling value for the workspace but now that this value was moved to the Workspace in a Popup then the code needed some changes so we can change the Geometry Scaling value using the Popup.

zeusongit · 2023-01-26T18:59:03Z

@RobertGlobant20 Can you take a look at the conflicts?

RobertGlobant20 · 2023-01-26T23:21:50Z

@RobertGlobant20 Can you take a look at the conflicts?

@zeusongit conflicts fixed

* DYN-4964-WorkingRange-Popup I've added a new button in the Workspace that when is clicked will show a popup containing the working ranges and the one currently selected. This new button will show a different image when the mouse is hover and when is clicked, also I've added a tooltip. For implementing this functionality I've added a new Popup (GeometryScalingPopup.xaml) and it's corresponding ViewModel. Finally I've added a converter that will receive as a parameter the current Working Range and will return a Brush with a specific color so the checkmark will be visible or not. * DYN-4964-WorkingRange-Popup CodeReview1 Added functionality for the new DefaultGeometryScaling property that will be serialized in the DynamoSettings.xml. Also I've disconnected the functionality of selecting the Geometry Scale for the current Workspace in the Preferences panel, now will be selected from the Dynamo workspace and will be serialized in the dyn file (as currently is happening). * DYN-4964-WorkingRange-Popup CodeReview1 Updated the string shown in Preferences panel (Geometry Scaling section) and the tooltip showed when the mouse is over the new Workspace button. * Build Fix When merging master to my branch there were some changed that I didn't noticed in the PR so I'm reverting back those changes. * DYN-4964-WorkingRange-Popup CodeReview 2 Fixed several comments also several methods were removed (like RadioGeometryScaling_Checked method) or moved The property GeoScalingViewModel was moved from DynamoViewModel to WorkspaceViewModel.. The property CurrentGeometryScaling was deleted due that was duplicating a functionality. * DYN-4964-WorkingRange-Popup CodeReview 2 When changing the Workspace Geometry Scaling it was not running the graph so I did some changes so it will be running the graph every time is updated. * DYN-4964-WorkingRange-Popup CodeReview 2 Add functionality for when a custom node is created the Workspace Scale Factor is set. Updating and removing some comments and also I started to add the unit test. * DYN-4964-WorkingRange-Popup CodeReview2 Updating Unit Test * DYN-4964-WorkingRange-Popup Fixing Tests I did the next fixes: The test TestImportCopySettings() was failing due that was reading the DynamoSettings-NewSettings.xml and comparing against the properties in PreferencesSetting so the DefaultScaleFactor was missing in the DynamoSettings-NewSettings.xml file. The test PreferencesGeoScaling_RunGraph_Automatic due that was opening the Preferences panel and changing the Geometry Scaling value for the workspace but now that this value was moved to the Workspace in a Popup then the code needed some changes so we can change the Geometry Scaling value using the Popup.

This reverts commit a526390.

* Dyn 5347 unified UI information icons (#13706) * standardizing information icons in the preference settings * Defending code (#13696) * Defending code * refining code * Improve Package Manager search sort order (#13700) * add search sort order * Add option to preview or hide preview of all geometry in a group and Fix top menu pixel difference (#13702) * Adjust border to fix 1 pixel anomaly * remove unused login grid * add logic to toggle preview for group * add analytics * Preview > Preview Geometry * ensure that signout option no seen when user sign out * DYN-4964-WorkingRange-Popup (#13656) * DYN-4964-WorkingRange-Popup I've added a new button in the Workspace that when is clicked will show a popup containing the working ranges and the one currently selected. This new button will show a different image when the mouse is hover and when is clicked, also I've added a tooltip. For implementing this functionality I've added a new Popup (GeometryScalingPopup.xaml) and it's corresponding ViewModel. Finally I've added a converter that will receive as a parameter the current Working Range and will return a Brush with a specific color so the checkmark will be visible or not. * DYN-4964-WorkingRange-Popup CodeReview1 Added functionality for the new DefaultGeometryScaling property that will be serialized in the DynamoSettings.xml. Also I've disconnected the functionality of selecting the Geometry Scale for the current Workspace in the Preferences panel, now will be selected from the Dynamo workspace and will be serialized in the dyn file (as currently is happening). * DYN-4964-WorkingRange-Popup CodeReview1 Updated the string shown in Preferences panel (Geometry Scaling section) and the tooltip showed when the mouse is over the new Workspace button. * Build Fix When merging master to my branch there were some changed that I didn't noticed in the PR so I'm reverting back those changes. * DYN-4964-WorkingRange-Popup CodeReview 2 Fixed several comments also several methods were removed (like RadioGeometryScaling_Checked method) or moved The property GeoScalingViewModel was moved from DynamoViewModel to WorkspaceViewModel.. The property CurrentGeometryScaling was deleted due that was duplicating a functionality. * DYN-4964-WorkingRange-Popup CodeReview 2 When changing the Workspace Geometry Scaling it was not running the graph so I did some changes so it will be running the graph every time is updated. * DYN-4964-WorkingRange-Popup CodeReview 2 Add functionality for when a custom node is created the Workspace Scale Factor is set. Updating and removing some comments and also I started to add the unit test. * DYN-4964-WorkingRange-Popup CodeReview2 Updating Unit Test * DYN-4964-WorkingRange-Popup Fixing Tests I did the next fixes: The test TestImportCopySettings() was failing due that was reading the DynamoSettings-NewSettings.xml and comparing against the properties in PreferencesSetting so the DefaultScaleFactor was missing in the DynamoSettings-NewSettings.xml file. The test PreferencesGeoScaling_RunGraph_Automatic due that was opening the Preferences panel and changing the Geometry Scaling value for the workspace but now that this value was moved to the Workspace in a Popup then the code needed some changes so we can change the Geometry Scaling value using the Popup. * Dyn 4964 popup geo scaling bugs (#13717) * DYN-4964-PopupGeoScaling-Bugs Fixing the next bugs reported by Aabi: - The Popup was not closing when clicking in the Dynamo workspace (adding a similar fix like the Workspace ContextMenu). - Adding a shadow over the new Geometry Scaling popup icon. * DYN-4964-WorkingRange-Popup Bug fixes There was a missing case that when the user click a Dynamo menu the Popup was not closing then I added some extra code to close it. * DYN-4964-WorkingRange-Popup Bug Code Review1 Removing extra trailing spaces. * Do not force user login for package search operation (#13725) * restrict user login for pkg search * check login state * Revert "Dyn 4964 popup geo scaling bugs (#13717)" This reverts commit 35005c3. * Revert "DYN-4964-WorkingRange-Popup (#13656)" This reverts commit a526390. * Markdown procedural image location (#13693) * Markdown procedural image location - fixed hard-coded image location - now identifies image location * Fixed Failing Tests - caught a bug causing issues when no image is present * Revert "Markdown procedural image location (#13693)" This reverts commit 299bbe9. * Address review comments for 2.17.1 cherrypick PR (#13729) --------- Co-authored-by: filipeotero <[email protected]> Co-authored-by: jesusalvino <[email protected]>

RobertGlobant20 requested a review from QilongTang January 4, 2023 19:14

RobertGlobant20 added 4 commits January 17, 2023 11:27

Merge branch 'master' into DYN-4964-WorkingRange-Popup

1c4ce8a

DYN-4964-WorkingRange-Popup CodeReview1

c4a8c4e

Updated the string shown in Preferences panel (Geometry Scaling section) and the tooltip showed when the mouse is over the new Workspace button.

Merge branch 'master' into DYN-4964-WorkingRange-Popup

0542299

Build Fix

f119e8d

When merging master to my branch there were some changed that I didn't noticed in the PR so I'm reverting back those changes.