Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require file extension for files to be copied #13628

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

mjkkirschner
Copy link
Member

Purpose

change was made here to require file paths, I'm not sure why. #11798
@QilongTang can you take a look too see if removing this check is ok?

see an issue here #13617

I think the use case is definitely valid, many files don't have an extension.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang
Copy link
Contributor

@mjkkirschner I agree, seems too much of a restriction

@QilongTang QilongTang merged commit 8c5399e into master Dec 11, 2022
@QilongTang QilongTang deleted the mjkkirschner-patch-1 branch December 11, 2022 02:29
@QilongTang
Copy link
Contributor

@mjkkirschner Do you think this would be good to include in 2.17.0, feel this one is not so risky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants