DYN-4304-ContextMenu-Direction #13624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When showing the NotificationsCenter popup and the Windows10 Handedness is Right-handed then the popup was shown in the wrong location then I implemented a fix that will be setting temporally the field _menuDropAlignment (this one modifies the Handedness) so in this way if the Handedness is Right-handed we will be setting this to Left-handed and the popup will be displayed in the right direction.
|
GIF showing the bug, then the Popup is shown in the wrong position (Handedness = Right-handed). |
|
GIF showing the popup location after the fix (Dynamo starts with Handedness = Right-handed but later is change temporally). |
QilongTang
approved these changes
Dec 10, 2022
QilongTang
reviewed
Dec 10, 2022
| { | ||
| var t = typeof(SystemParameters); | ||
| var field = t.GetField("_menuDropAlignment", BindingFlags.NonPublic | BindingFlags.Static); | ||
| field.SetValue(null, false); //Set the field to Left-handed(false) |
There was a problem hiding this comment.
Is this something that will be serialized or is only a temporary setting?
8 tasks
QilongTang
pushed a commit
that referenced
this pull request
Dec 13, 2022
When showing the NotificationsCenter popup and the Windows10 Handedness is Right-handed then the popup was shown in the wrong location then I implemented a fix that will be setting temporally the field _menuDropAlignment (this one modifies the Handedness) so in this way if the Handedness is Right-handed we will be setting this to Left-handed and the popup will be displayed in the right direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing Dynamo Popup Directions
When showing the NotificationsCenter popup and the Windows10 Handedness is Right-handed then the popup was shown in the wrong location then I implemented a fix that will be setting temporally the field _menuDropAlignment (this one modifies the Handedness) so in this way if the Handedness is Right-handed we will be setting this to Left-handed and the popup will be displayed in the right direction.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Dynamo Popup Directions
Reviewers
@QilongTang
FYIs