Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-4810_Dots in Preview Bubble and Watch sublists are rendered off-axis #13608

Merged
merged 1 commit into from
Dec 7, 2022
Merged

DYN-4810_Dots in Preview Bubble and Watch sublists are rendered off-axis #13608

merged 1 commit into from
Dec 7, 2022

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 6, 2022 •
edited
Loading

Purpose

This is a bug-fix to the Dots in Preview Bubble and Watch sublists are rendered off-axis issue. It fixes the misalignment of the dots in the sub-list node menu.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • fix to the misalignment of the sub-list dots

Reviewers

@reddyashish

FYIs

@Amoursol

@dnenov
Update to WatchTree.xaml
6e2f45a 
- fix to the misalignment of the sub-list dots
@Amoursol
Copy link
Contributor

Amoursol commented Dec 6, 2022

@dnenov - If you zoom in to the fixed version, it looks like it's very slightly still skewed to the left. Is it possible to nudge it a tiny bit more?

@dnenov
Copy link
Collaborator Author

dnenov commented Dec 6, 2022

Great catch, keen eye! However, the shift that we need to do is half of a pixel, and we cannot do that. What we have here is a rectangle of 1px width and an ellipse with 5px width and height. They cannot get centrally aligned it seems and will be offset by 0.5px in either left or right direction. I spent most of the time trying to find a solution for exactly this issue, but I don't think it exists. These are dynamic lines as well, so it will be tough to replace them with an icon, which is what I also though about doing.

@dnenov dnenov changed the title Update to WatchTree.xaml DYN-4810_Dots in Preview Bubble and Watch sublists are rendered off-axis Dec 6, 2022
@Amoursol
Copy link
Contributor

Amoursol commented Dec 6, 2022

Great catch, keen eye! However, the shift that we need to do is half of a pixel, and we cannot do that. What we have here is a rectangle of 1px width and an ellipse with 5px width and height. They cannot get centrally aligned it seems and will be offset by 0.5px in either left or right direction. I spent most of the time trying to find a solution for exactly this issue, but I don't think it exists. These are dynamic lines as well, so it will be tough to replace them with an icon, which is what I also though about doing.

Ah, gotcha. No worries in that case! I'm cool with it as is :D

@reddyashish reddyashish marked this pull request as ready for review December 7, 2022 13:43
@reddyashish
Copy link
Contributor

@QilongTang Do you want to get this in for 2.17?

@QilongTang
Copy link
Contributor

@QilongTang Do you want to get this in for 2.17?

Sure, this looks like a good one to include

@reddyashish reddyashish added this to the 2.17.0 milestone Dec 7, 2022
@reddyashish reddyashish merged commit 5eeafd3 into DynamoDS:master Dec 7, 2022
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request Dec 7, 2022
@dnenov @reddyashish
Update to WatchTree.xaml (DynamoDS#13608)
e13e968 
- fix to the misalignment of the sub-list dots

(cherry picked from commit 5eeafd3)
@reddyashish reddyashish mentioned this pull request Dec 7, 2022
Merged
8 tasks
reddyashish added a commit that referenced this pull request Dec 7, 2022
@reddyashish @dnenov
Cherrypicks - PR [13608] [13611] (#13616)
f82401c 
* DYN-4895_Image Update to Learn More documentation (#13611)

* Image Update to Learn More documentation

- updated embedded legacy images inside html documentation

* White background added for clarity

- transparent images exported from Dynamo workspace were a bit unclear. Added white background to help visibility

(cherry picked from commit 89c55de)

* Update to WatchTree.xaml (#13608)

- fix to the misalignment of the sub-list dots

(cherry picked from commit 5eeafd3)

Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dnenov @Amoursol @reddyashish @QilongTang