Include all files from Markdown Directory to published package #13607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avidit @reddyashish @zeusongit I tested locally that it works as expected. PTAL |
reddyashish
approved these changes
Dec 6, 2022
|
@avidit I am going to merge this and request your testing on master first, if you think this is good, we can put into 2.17, what do you think? |
QilongTang
added a commit
that referenced
this pull request
Dec 7, 2022
* update * add all files under Markdown Dir to pkg * update comment * update tests * update test * update tests * update comments * update test
QilongTang
added a commit
that referenced
this pull request
Dec 7, 2022
* Include all files from Markdown Directory to published package (#13607) * update * add all files under Markdown Dir to pkg * update comment * update tests * update test * update tests * update comments * update test * Adding localization for the sign in button states (#13612) * DYN-5322 Update ML NodeAutocomplete Documentation (#13602) * DYN-5322-Doc-MLNodeAutocomplete I updated the NodeAutocompleteDcoumentation.html to match the docx document attached to the Jira task. For the GIFs/PNG updated I did the next actions: - Modified the original images resolution to 450 x XXX (according to the aspect ratio). - Compressed the modified image/GIF so it will use the minimum size in the html file when converted to Base 64 (otherwise the WebView2 component was crashing). - Convert the Image/GIF to Base64 content and put it in the HTML file. * DYN-5322-Doc-MLNodeAutocomplete CodeReview1 I've added the MouseDown event and the handler so every time the question mark symbol is clicked in the preferences panel the DocumentationBrowser ML NodeAutocomplete documentation will be opened. Co-authored-by: filipeotero <[email protected]> Co-authored-by: Roberto T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Follow-up of #13577, users requested that we include all files under the markdown directory in the published package instead of only md files. This is because there could be markdown files depending on the local images or other resources.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Include all files from Markdown Directory to published package
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of