Dyn 5427 confidence threshold autocomplete ml

[jesusalvino]

Purpose

Implementation of the story https://jira.autodesk.com/browse/DYN-5427

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @filipeotero

[jesusalvino]

[reddyashish]

LGTM. The ML autocomplete request here https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs#L38 should be using these values from settings. Can you make that change as well and also resolve the conflicts.

[jesusalvino]

LGTM. The ML autocomplete request here https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs#L38 should be using these values from settings. Can you make that change as well and also resolve the conflicts.

Done.

[reddyashish]

Looks good to me with one comment. The only test failing is the IfSubmenuOpenOnMouseHover which is flaky.

[zeusongit]

LGTM with one comment

[jesusalvino]

Looks good to me with one comment. The only test failing is the IfSubmenuOpenOnMouseHover which is flaky.

that test works for me locally

[reddyashish]

Yes that test was failing intermittently on master-5. We can ignore that.

[reddyashish]

The last job has this failing test [Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings]
Can you check it and lets run the job again,

[jesusalvino]

The last job has this failing test [Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings] Can you check it and lets run the job again,

Done.

[reddyashish]

Thanks @jesusalvino. We can merge this after the job gets finished. Once @QilongTang confirms if this can still get in for 2.17, we can cherry-pick it.