Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node icons #13528

Merged
merged 2 commits into from
Nov 18, 2022
Merged

update node icons #13528

merged 2 commits into from
Nov 18, 2022

Conversation

pinzart90
Copy link
Contributor

@pinzart90 pinzart90 commented Nov 16, 2022

https://jira.autodesk.com/browse/DYN-5073
https://jira.autodesk.com/browse/DYN-5244

Purpose

Fix icon sizes for :
Solid.Repair, Surface.Repair
Curve.NormalAtParameter
PolyCurve.Heal

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pinzart90 pinzart90 changed the title update Solid.Repair and Surface.Repair icons update node icons Nov 16, 2022
@pinzart90
Copy link
Contributor Author

@aparajit-pratap looks like we need to add all new icons to the GeometryUIWpf/ProtoGeometryImages.resx file in order for them to be displayed in dynamo.
Not sure why there are a bunch in src/Resources/ProtoGeometry/ too

@QilongTang QilongTang added this to the 2.17.0 milestone Nov 18, 2022
@QilongTang
Copy link
Contributor

Reported regression is sporadic, merging. Please also cherry pick it

@QilongTang QilongTang merged commit 530bbf1 into master Nov 18, 2022
@QilongTang QilongTang deleted the update_icons branch November 18, 2022 18:22
pinzart90 added a commit that referenced this pull request Nov 21, 2022
* update Solid.Repair and Surface.Repair icons

* update

Co-authored-by: pinzart <[email protected]>
@pinzart90 pinzart90 mentioned this pull request Nov 21, 2022
8 tasks
@aparajit-pratap
Copy link
Contributor

@aparajit-pratap looks like we need to add all new icons to the GeometryUIWpf/ProtoGeometryImages.resx file in order for them to be displayed in dynamo. Not sure why there are a bunch in src/Resources/ProtoGeometry/ too

I don't think that the png files are required in src/Resources/ProtoGeometry/ as they are embedded resources, however, If I'm not wrong, I believe they are submitted in order to track them easily.

pinzart90 added a commit that referenced this pull request Nov 21, 2022
* update Solid.Repair and Surface.Repair icons

* update

Co-authored-by: pinzart <[email protected]>
pinzart90 added a commit that referenced this pull request Nov 21, 2022
* update Solid.Repair and Surface.Repair icons

* update

Co-authored-by: pinzart <[email protected]>
pinzart90 added a commit that referenced this pull request Nov 21, 2022
* update node icons (#13528)

* update Solid.Repair and Surface.Repair icons

* update

Co-authored-by: pinzart <[email protected]>

* UPDATE

Co-authored-by: pinzart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants