add null check to notifications center location change handler. #13520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Looking at common CER crashes for 2.16 I notice multiple crashes for a null reference exception when the dynamo window is moved.
It appears that in rare circumstances you can move the Dynamo window before the
NotificationsCenter
constructor is finished executing, this will kick off the location changed handler, which will try to access the UI popup - but it has not been created yet.Just add a null check.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Fix crash when moving Dynamo Window.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of