Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating ML node autocomplete. #13496

Merged
merged 22 commits into from
Nov 17, 2022
Merged

Integrating ML node autocomplete. #13496

merged 22 commits into from
Nov 17, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Nov 10, 2022 •
edited
Loading

Purpose

Integrating ML node autocomplete.

Task: https://jira.autodesk.com/browse/DYN-5335

API Schema info: https://wiki.autodesk.com/pages/viewpage.actionspaceKey=~misolm&title=Dynamo+Node+Autocomplete+-+Schema

ML node autocomplete

To-do changes

  1. Using temporary token, change it to use oAuth sign-in. done
  2. Add tests done
  3. Some UI improvements.
    a) Background is not transparent - fixed
    b) Hover state on item should be consistent with hover state in library - fixed
    c) Search bar - matching the figma link - fixed
    d) Switch method icon rotate 90% degrees, hover blue should be the icon itself instead of the background - fixed
    e) Scrolling of the nodes in autocompletion window has regressed - fixed

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Integrating ML node autocomplete.

Reviewers

@QilongTang @zeusongit

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang
Copy link
Contributor

@reddyashish Do we get confidence as part of the response? Since from the gif, it is not there yet, just curious

@QilongTang QilongTang added this to the 2.17.0 milestone Nov 10, 2022
@reddyashish
Copy link
Contributor Author

@QilongTang Yes we do get the confidence score, I am adding a field to show that. Will push those changes.

varvaratou
varvaratou reviewed Nov 10, 2022
View reviewed changes
src/DynamoCore/Search/SearchElements/MLNodeSearchElement.cs Show resolved Hide resolved
src/DynamoCoreWpf/App.config Outdated Show resolved Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs Outdated Show resolved Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs Outdated Show resolved Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs Outdated Show resolved Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs Outdated Show resolved Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs Outdated Show resolved Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs Show resolved Hide resolved
@QilongTang
Copy link
Contributor

@reddyashish The job reported failed but I dont see any regressions? Can you double check

@reddyashish
Copy link
Contributor Author

Failed while getting the package: Error downloading 'adp-desktop-sdk_win_release_intel64_v140.4.2.0'
Running it again.

@reddyashish
Copy link
Contributor Author

Job passed. Merging this.

@reddyashish reddyashish merged commit 34fe0f1 into DynamoDS:master Nov 17, 2022
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Nov 17, 2022
@reddyashish
Integrating ML node autocomplete. (DynamoDS#13496)
1ef0c9c 
* Integrate ML Node-Autocompletion,

* Update NodeModel.cs

* Update NodeModel.cs

* some changes

* more changes

* Update NodeAutoCompleteSearchControl.xaml

* Fix edge cases and UI improvements.

* update

* Update NodeAutoCompleteSearchControl.xaml

* fix highlighting items.

* fix

* Port name for variable input nodes.

* Add base test.

* addressing comments.

* Fix the edge cases for search results.

* Clean up code

* Update NodeAutoCompleteSearchViewModel.cs

* refactoring.

* updates

* Use IDSDK token for authentication

* updates

(cherry picked from commit 34fe0f1)
@reddyashish reddyashish mentioned this pull request Nov 17, 2022
Merged
8 tasks
reddyashish added a commit that referenced this pull request Nov 17, 2022
@reddyashish
Integrating ML node autocomplete. (#13496) (#13533)
d9302ab 
* Integrate ML Node-Autocompletion,

* Update NodeModel.cs

* Update NodeModel.cs

* some changes

* more changes

* Update NodeAutoCompleteSearchControl.xaml

* Fix edge cases and UI improvements.

* update

* Update NodeAutoCompleteSearchControl.xaml

* fix highlighting items.

* fix

* Port name for variable input nodes.

* Add base test.

* addressing comments.

* Fix the edge cases for search results.

* Clean up code

* Update NodeAutoCompleteSearchViewModel.cs

* refactoring.

* updates

* Use IDSDK token for authentication

* updates

(cherry picked from commit 34fe0f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeusongit zeusongit zeusongit left review comments

@varvaratou varvaratou varvaratou left review comments

@mjkkirschner mjkkirschner mjkkirschner left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@reddyashish @QilongTang @mjkkirschner @varvaratou @zeusongit