Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving SelectedPackagePathForInstall #13476

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Saving SelectedPackagePathForInstall #13476

merged 1 commit into from
Nov 7, 2022

Conversation

jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Nov 7, 2022

Purpose

Saving the SelectedPackagePathForInstall setting in memory just after importing as part of the story https://jira.autodesk.com/browse/DYN-5398 in order to display a proper message to the user.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@filipeotero @RobertGlobant20

@QilongTang QilongTang added this to the 2.17.0 milestone Nov 7, 2022
@QilongTang
Copy link
Contributor

@jesusalvino would you look at the regression?

@QilongTang QilongTang mentioned this pull request Nov 7, 2022
8 tasks
@jesusalvino
Copy link
Contributor Author

@jesusalvino would you look at the regression?

it passed for me locally

imagen

@QilongTang QilongTang merged commit 589332f into DynamoDS:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants