update to ASM 229 #13451
Merged
update to ASM 229 #13451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzart90
approved these changes
Nov 1, 2022
mjkkirschner
commented
Nov 2, 2022
| @@ -87,6 +87,7 @@ public void TestTextFromDynamoText() | |||
| #region Mesh Toolkit Tests | |||
|
|
|||
| [Test] | |||
| [Category("Failure")]//TODO_update meshtoolkit for asm229 | |||
There was a problem hiding this comment.
@aparajit-pratap you were right, I have to mark these tests as failing for now, I can look into updating meshtoolkit to latest AMT after this gets merged and then unmark these.
|
@aparajit-pratap @pinzart90 @sm6srw - this has now passed: though test time has increased to 45~ minutes from 30~ I am going to merge this. My guesses are:
|
| @@ -92,6 +92,50 @@ private static List<string> ProductsWithASM | |||
| "ADPSDKUI.DLL", | |||
| "ADPSDKCORE.DLL" | |||
There was a problem hiding this comment.
Do we want to continue preloading ADP dll's for ASM228?
There was a problem hiding this comment.
hmm, good question - I will file a followup to look into this as we'd have to make changes on the LibG side as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
related:
https://git.autodesk.com/Dynamo/DynamoSelfServe/pull/83/
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Support latest ADSK geometry kernel.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of