Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to navigate to start and end nodes of a connector. #13429

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Oct 25, 2022

Purpose

Task: https://jira.autodesk.com/browse/DYN-4836

Added the functionality to focus on the start/end nodes of the connector. These options are added to the connector context menu. I tried adding the input binding for '< 'and '>' as shortcut keys but had issues triggering them.
Will also add some tests.

node naviagtion from connectors

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Add functionality to navigate to start and end nodes of a connector.

Reviewers

@QilongTang @zeusongit

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add tests if apply

@reddyashish
Copy link
Contributor Author

Added the tests.

@reddyashish
Copy link
Contributor Author

master-5 seems to be failing for most of the jobs.
Self-serve job on master-15 passed: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1097/

@QilongTang QilongTang merged commit 64f68b0 into DynamoDS:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants