Python editor text zoom #13427
Merged
Python editor text zoom #13427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amoursol The clean-up commit is not clean, please fix the build error.. FYI: you cant rename the event hanlder without updating the reference in UI code |
QilongTang
approved these changes
Oct 25, 2022
| private const double FONT_MAX_SIZE = 60d; | ||
| private const double FONT_MIN_SIZE = 5d; | ||
|
|
||
| // Update function, increases/decreases by a specific increment |
There was a problem hiding this comment.
- This comment doesn't really make sense.
- public methods should use ///summary comments.
- Why is this public?
There was a problem hiding this comment.
@mjkkirschner it's code from elsewhere ported. For sure not ideal for Dynamo. @QilongTang is fixing it for me 😊
There was a problem hiding this comment.
Oh missed this one, I will update this in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding in the ability to increase or decrease the text font size in the Python editor, by using
CTRLand their middle-mouse scroll.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@DynamoDS/dynamo
FYIs
@QilongTang