Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node descriptions in Core Node Models library #13424

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

hwahlstrom
Copy link
Collaborator

@hwahlstrom hwahlstrom commented Oct 24, 2022

Purpose

Updating Core Node Models library node descriptions to adhere to node description content pattern.

image

image

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Updated descriptions for several nodes in the Core Node Models library to improve clarity and consistency.

Reviewers

@Amoursol

FYIs

@hwahlstrom hwahlstrom requested a review from QilongTang October 24, 2022 20:14
@hwahlstrom hwahlstrom added DNM Do not merge. For PRs. WIP and removed DNM Do not merge. For PRs. labels Oct 24, 2022
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but usually the designer files are updated as well. Did you edit using a regular editor instead of visual studio? But I think the file will be updated build time..

@QilongTang QilongTang added this to the 2.17.0 milestone Oct 24, 2022
@hwahlstrom hwahlstrom changed the title Node description updates 1 Update node descriptions in Core Node Models library Oct 25, 2022
@QilongTang
Copy link
Contributor

QilongTang commented Oct 26, 2022

Two regressions found, must be some tests depending on validation of node descriptions:
Test Result (2 failures / DynamoCoreWpfTests.PreviewBubbleTests.Watch_ColorRange
Dynamo.Tests.SerializationTests.NodeDescriptionDeserilizationTest

Working on the fix

@QilongTang QilongTang merged commit 889d6bf into master Oct 26, 2022
@QilongTang QilongTang deleted the Node-description-updates branch October 26, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants