Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple globalization UI bug fixes #13419

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

zeusongit
Copy link
Contributor

Purpose

DYN-5234
"Select connected" and "Break connection" contextual menu option truncated - UI layout issue

  • Added min max widths

Screen Shot 2022-10-21 at 1 10 09 PM

DYN-5024
Truncated "Reset" string in Publish Package dialog / Dynamo for Revit - UI layout issue

  • Increased window width and replaced "Directory" with "Path"

Screen Shot 2022-10-21 at 6 35 49 PM
Screen Shot 2022-10-21 at 6 43 55 PM
Screen Shot 2022-10-21 at 7 25 42 PM

DYN-5233
Overlapping in "Agreement to Collect Usability Data" dialog - UI layout issue

  • Increased window width.

Screen Shot 2022-10-21 at 1 53 50 PM
Screen Shot 2022-10-21 at 1 56 42 PM

DYN-3449
Edit window in Dynamo to handle more content OOTB

  • Increased text box height to fit 5 lines

Screen Shot 2022-10-21 at 4 57 28 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • Multiple globalization UI bug fixes

Reviewers

@DynamoDS/dynamo

@QilongTang
Copy link
Contributor

Rerunning the PR check to make sure

@QilongTang
Copy link
Contributor

@QilongTang QilongTang merged commit e1ef655 into DynamoDS:master Oct 24, 2022
@QilongTang QilongTang added this to the 2.17.0 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants