Dyn 5288 node autocomplete improvements #13410
Conversation
|
Case 1: no results (0 items)
Case 2: the result has at least one item assuming each node could be by recommendation or by use
Case 3: Confidence score are under a threshold, assuming the minimum value is 50 and some result nodes are under it
Case 4: Confidence score are under a threshold, assuming the minimum value is 50 and all results nodes are under it
|
|
@jesusalvino looking awesome as a first pass! A couple of comments:
|
|
@Amoursol I have already discussed with @Jingyi-Wen about the Case 2: Assuming that each node from the ML result could be "by use" (recently used) or "by recommendation", this case shows 2 results and they are only by use, that's why the "no recommendations message" is displayed, it probably rarely happens, please let me know if we are good with the implementation of the mockups, any change / update is welcome. |
Ah, that makes sense. In this case, please do keep it as is! |
src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// Indicates if display the Low confidence option and Tooltip | ||
| /// </summary> | ||
| public bool DisplayLowConfidence { get; set; } |
There was a problem hiding this comment.
Do we need all of these properties? It seems most of them will have same/opposite value of Models.NodeAutocompleteSuggestion.MLRecommendation?
There was a problem hiding this comment.
Yes, according to the Mockups we have different messages and behavior based on the type of the results: by use, recommendations and confidence score.
| } | ||
| RaisePropertyChanged(nameof(DisplayNoRecommendationsLowConfidence)); |
There was a problem hiding this comment.
First I feel these better not be raised manually but part of the setter so they are automatic?
Also this function PopulateAutoCompleteCandidates() is called a lot but do we need to set these values all the time? Can we just set these values everytime when user pick the autocomplete method?
| get | ||
| { | ||
| return dynamoViewModel.PreferenceSettings.DefaultNodeAutocompleteSuggestion == Models.NodeAutocompleteSuggestion.MLRecommendation; | ||
| } |
There was a problem hiding this comment.
removed setter and changed the view code to be one way binding
|
@jesusalvino After my changes, user should be able to switch back and forth as well, see below:
|
|
Got approval from @jesusalvino on slack. Merging in for follow up changes. |
Purpose
Implement the story https://jira.autodesk.com/browse/DYN-5288
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero