Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown input nodes when running from player with Dynamo open #13403

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Oct 17, 2022

Purpose

Fixes AGD-2777

When running a graph from Dynamo Player while the Dynamo UI was open, the value and UI display of dropdown nodes was not updated consistently.

  • DropDown.UpdateValueCore uses the SelectedIndex setter instead of its own logic.
  • The DropDown.SelectedIndex setter runs RaisePropertyChanged("SelectedString"). (Previously it changed selectedString but did not alert the UI of the change.)

Opportunistic fixes:

  • The DropDown.SelectedString setter runs RaisePropertyChanged("SelectedIndex"). (Previously it changed selectedIndex but did not alert the UI of the change.)
  • The DropDown.SelectedString setter does nothing if the given value is the same as the current value.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.

Reviewers

@saintentropy

@twastvedt twastvedt added the DynamoPlayer Dynamo Player label Oct 17, 2022
@twastvedt twastvedt changed the title Agd 2777 player dropdown inputs Fix dropdown input nodes when running from player with Dynamo open Oct 17, 2022
@twastvedt twastvedt requested a review from QilongTang November 8, 2022 15:19
@QilongTang QilongTang added this to the 2.17.0 milestone Nov 8, 2022
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment then LGTM

@QilongTang
Copy link
Contributor

Waiting for all PR checks to finish

@QilongTang
Copy link
Contributor

@QilongTang QilongTang merged commit 8b01ace into master Nov 9, 2022
@QilongTang QilongTang deleted the AGD-2777-player-dropdown-inputs branch November 9, 2022 00:11
@QilongTang
Copy link
Contributor

@twastvedt I assume the actual testing will be done by Vera team on this

@twastvedt
Copy link
Contributor Author

@QilongTang Yes we will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DynamoPlayer Dynamo Player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants