-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropdown input nodes when running from player with Dynamo open #13403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then LGTM
Waiting for all PR checks to finish |
Reported regression is a glitch |
@twastvedt I assume the actual testing will be done by Vera team on this |
@QilongTang Yes we will! |
Purpose
Fixes AGD-2777
When running a graph from Dynamo Player while the Dynamo UI was open, the value and UI display of dropdown nodes was not updated consistently.
DropDown.UpdateValueCore
uses theSelectedIndex
setter instead of its own logic.DropDown.SelectedIndex
setter runsRaisePropertyChanged("SelectedString")
. (Previously it changedselectedString
but did not alert the UI of the change.)Opportunistic fixes:
DropDown.SelectedString
setter runsRaisePropertyChanged("SelectedIndex")
. (Previously it changedselectedIndex
but did not alert the UI of the change.)DropDown.SelectedString
setter does nothing if the given value is the same as the current value.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@saintentropy