Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to preferences panel #13358

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Sep 30, 2022

Purpose

Add the following settings to preferences panel. Serialize user preference.

https://jira.autodesk.com/browse/DYN-5203

preference settings

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Add settings to preferences panel

Reviewers

@QilongTang @jesusalvino @Amoursol

@reddyashish reddyashish requested a review from a team September 30, 2022 14:34
@QilongTang QilongTang added this to the 2.17.0 milestone Oct 1, 2022
@QilongTang
Copy link
Contributor

QilongTang commented Oct 3, 2022

LGTM, Can we append some tests to serialize the new settings? I think we already have a preference setting somewhere so you only need to touch the settings.xml and update the test.

@reddyashish
Copy link
Contributor Author

Yes, looking into the tests now.

@QilongTang
Copy link
Contributor

Oops, there is some conflict to address with #13355

@reddyashish
Copy link
Contributor Author

@QilongTang Added the BackupInterval and HardwareAcceleration property to the preferences-serialization tests. MaxNumRecentFiles is already added to this test and we have 2 separate tests for the loading of PythonTemplate. We also have a CanUpdatePythonTemplateSettings() test in the CoreTests class that checks: changing the PythonTemplate. So that should cover it.

@QilongTang QilongTang merged commit a6bbf1b into DynamoDS:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants