Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #13352

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Update README.md #13352

merged 2 commits into from
Sep 29, 2022

Conversation

Amoursol
Copy link
Contributor

Purpose

Updated the Node.js install instructions

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Updated the Node.js install instructions in the DynamoDS ReadMe.md

Reviewers

@DynamoDS/autodesk
@mjkkirschner

FYIs

@QilongTang

Updated the Node.js install instructions
README.md Outdated
@@ -33,6 +33,9 @@ You will need the following to build the latest Dynamo on Windows:
- [Microsoft Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) (any edition)
- Microsoft .NET Framework 4.8 (included with Visual Studio 2019)
- Node.js v16 and npm v8
- - [Download](https://nodejs.org/en/download/) and install the latest LTS version of Node.js
- - Open up your Command Prompt and check you have successfully installed Node by inputting `node -v`. If you have Node installed, it will tell you the version.
- - In the Command Prompt, install Node Package Manager (NPM) by typing `npm install` and checking you have correctly installed it with `npm -v`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step is not necessary - npm is installed when you run the node installer.
npm install will not install npm, it will install the packages specified by the package.json / package lock.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool - updating now!

Removed step to install npm directly
@mjkkirschner mjkkirschner merged commit 912a25b into master Sep 29, 2022
@mjkkirschner mjkkirschner deleted the Amoursol-ReadMeUpdate branch September 29, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants