DYN-5245-DynamoRevit-Crash-WhenExiting #13299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added some code for stopping the WebView2 instance when Dynamo is being closed because otherwise is crashing and also not loading the notifications. Also the Dispose method was deleted due that we are doing the same in the new method added SuspendCoreWebviewAsync.
Removing call to TrySuspendAsync();
|
This is a GIF showing that is not crashing after closing Dynamo with notifications opened (@QilongTang notice that the second time that I open Dynamo in my computer is not loading notifications, it happens randomly) |
QilongTang
approved these changes
Sep 7, 2022
QilongTang
pushed a commit
that referenced
this pull request
Sep 7, 2022
* DYN-5245-Revit-NotificationCenter-Crashing I added some code for stopping the WebView2 instance when Dynamo is being closed because otherwise is crashing and also not loading the notifications. Also the Dispose method was deleted due that we are doing the same in the new method added SuspendCoreWebviewAsync. * DYN-5245-Revit-NotificationCenter-Crashing Removing call to TrySuspendAsync();
QilongTang
added a commit
that referenced
this pull request
Sep 7, 2022
* DYN-5245-DynamoRevit-CreateCustom UserDataFolder (#13293) * DYN-5245-Revit-NotificationCenter-Crashing Added code for create the WebView2 cache folder in the AppData location because when tries to create it inside C:\Program Files\Autodesk\Revit 2023\AddIns\DynamoForRevit is crashing due to permissions. * DYN-5245-Revit-NotificationCenter-Crashing Code Review Not using await for initializing WebView2 * DYN-5245-DynamoRevit-Crash-WhenExiting (#13299) * DYN-5245-Revit-NotificationCenter-Crashing I added some code for stopping the WebView2 instance when Dynamo is being closed because otherwise is crashing and also not loading the notifications. Also the Dispose method was deleted due that we are doing the same in the new method added SuspendCoreWebviewAsync. * DYN-5245-Revit-NotificationCenter-Crashing Removing call to TrySuspendAsync(); Co-authored-by: Roberto T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing crash in Dynamo for Revit when exiting Dynamo and notifications are displayed.
I added some code for stopping the WebView2 instance when Dynamo is being closed because otherwise is crashing and also not loading the notifications. Also the Dispose method was deleted due that we are doing the same in the new method added SuspendCoreWebviewAsync.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing crash in Dynamo for Revit when exiting Dynamo and notifications are displayed.
Reviewers
@QilongTang
FYIs