Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Greg and Analytics packages #13294

Merged
merged 4 commits into from
Sep 12, 2022
Merged

update Greg and Analytics packages #13294

merged 4 commits into from
Sep 12, 2022

Conversation

pinzart90
Copy link
Contributor

@pinzart90 pinzart90 commented Sep 6, 2022

Update Analytics to use the public nuget package (version 3.0.0 with namespace changes).
Update PackageManager client version - includes a fix to not throw exceptions in debug builds

@pinzart90 pinzart90 marked this pull request as ready for review September 8, 2022 17:38
@@ -137,6 +128,7 @@
<NodeHelpFiles Include="$(SolutionDir)..\doc\distrib\NodeHelpFiles\**\*.*" />
<OpenSourceLicenses Include="$(SolutionDir)..\doc\distrib\Open Source Licenses\**\*.*" />
<LocalizedResources Include="$(SolutionDir)..\extern\Localized\**\*.*" />
<LegacyBinariesToBinFolder Include="$(SolutionDir)..\extern\legacy_remove_me\bin\*\*" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this change for?

Copy link
Member

@mjkkirschner mjkkirschner Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought @aparajit-pratap just removed this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how that got there. Will revert this

@pinzart90 pinzart90 merged commit 63e5c2f into master Sep 12, 2022
@pinzart90 pinzart90 deleted the update_extern_packages branch September 12, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants