Fixed Bug Causing Dynamo Crash #13269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed a bug of incorrectly using color instead of brush in styles causing Dynamo crash
reddyashish
approved these changes
Aug 30, 2022
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
Aug 30, 2022
- fixed a bug of incorrectly using color instead of brush in styles causing Dynamo crash (cherry picked from commit 4855cd9)
8 tasks
reddyashish
added a commit
that referenced
this pull request
Aug 30, 2022
- fixed a bug of incorrectly using color instead of brush in styles causing Dynamo crash (cherry picked from commit 4855cd9) Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bugfix. Incorrectly used Color instead of SolidColorBrush causing Dynamo to crash.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
The Background value of the HintingInputStyle TextBox was being assigned a Color instead of SolidColorBrush, as it should have. This was causing a difficult-to-trace Crash when the dialog containing the textbox style was used.
Reviewers
@reddyashish