Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publish message box regarding package scans #13250

Merged
merged 8 commits into from
Aug 26, 2022
Merged

Add publish message box regarding package scans #13250

merged 8 commits into from
Aug 26, 2022

Conversation

zeusongit
Copy link
Contributor

Purpose

Add a message box before publishing package
Screen Shot 2022-08-25 at 4 35 40 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@avidit

@zeusongit zeusongit requested a review from reddyashish August 25, 2022 20:45
@zeusongit zeusongit merged commit 79ebac3 into DynamoDS:master Aug 26, 2022
zeusongit added a commit to zeusongit/Dynamo that referenced this pull request Aug 30, 2022
@zeusongit
Add publish message box regarding package scans (DynamoDS#13250)
70b8a9a 
* Update PublishPackageViewModel.cs
@zeusongit zeusongit mentioned this pull request Aug 30, 2022
Merged
8 tasks
QilongTang pushed a commit that referenced this pull request Aug 31, 2022
@zeusongit
Add publish message box regarding package scans (#13250) (#13276)
9fb6ffd 
* Update PublishPackageViewModel.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeusongit @QilongTang @reddyashish