Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize Color Picker imp #13203

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Localize Color Picker imp #13203

merged 4 commits into from
Aug 15, 2022

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Aug 10, 2022

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per https://jira.autodesk.com/browse/DYN-5027, add localization by passing in resource string to Advance button and Standard button.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Localize Color Picker imp

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 2.17.0 milestone Aug 10, 2022
@mjkkirschner
Copy link
Member

mjkkirschner commented Aug 11, 2022

hey @QilongTang I think there is some confusion here.

  1. cryotek bitmap font has nothing to do with the color picker AFAIK. It's a library for parsing fonts from a single bitmap - it's used I would guess for 3d labels in Helix3d.
  2. The color picker is a library from xceed - but we must tread carefully here as the license has changed for xceed and is now paid for commercial use I believe, even if they addressed whatever bug this is we could not update to the newer version.

@QilongTang
Copy link
Contributor Author

hey @QilongTang I think there is some confusion here.

  1. cryotek bitmap font has nothing to do with the color picker AFAIK. It's a library for parsing fonts from a single bitmap - it's used I would guess for 3d labels in Helix3d.
  2. The color picker is a library from xceed - but we must tread carefully here as the license has changed for xceed and is now paid for commercial use I believe, even if they addressed whatever bug this is we could not update to the newer version.

Oops, I guess I sent the issue to the wrong repo then. Closing it now

@QilongTang QilongTang changed the title Initialize Color Picker with current culture Localize Color Picker imp Aug 12, 2022
@QilongTang QilongTang marked this pull request as ready for review August 12, 2022 17:15
@QilongTang QilongTang modified the milestones: 2.17.0, 2.16.0 Aug 12, 2022
@QilongTang QilongTang merged commit 933f16c into master Aug 15, 2022
@QilongTang QilongTang deleted the ColorPickerLocalization branch August 15, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants