Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CustomNode WorkSpace first scenario and trusted bubble behavior #13197

Merged
merged 6 commits into from
Aug 12, 2022
Merged

Fixing CustomNode WorkSpace first scenario and trusted bubble behavior #13197

merged 6 commits into from
Aug 12, 2022

Conversation

jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Aug 9, 2022

Purpose

Fixing the second flow from the trusted bubble behavior with 2 workspaces when an user opens an already created .dyf file first.
https://jira.autodesk.com/browse/DYN-5089

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @filipeotero

@QilongTang
Copy link
Contributor

@jesusalvino The self serve failed, please check out regressions

@jesusalvino
Copy link
Contributor Author

jesusalvino commented Aug 11, 2022

@jesusalvino The self serve failed, please check out regressions

In a quick review it worked for me locally, I will check the rest
imagen
imagen

@QilongTang
Copy link
Contributor

There are some failures about geometry stuff which I feel is due to the ASM version update. Merging

@QilongTang QilongTang merged commit 07788fb into DynamoDS:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants