Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-5161 The "Show Connectors" feature should register newly placed nodes #13170

Merged
merged 8 commits into from
Sep 16, 2024
Merged

DYN-5161 The "Show Connectors" feature should register newly placed nodes #13170

merged 8 commits into from
Sep 16, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Aug 3, 2022 •
edited
Loading

Purpose

Per https://jira.autodesk.com/browse/DYN-5161 and https://jira.autodesk.com/browse/DYN-6218, fix a bug where new connectors were not hidden if setting in Dynamo has been changed by user. Now new connectors always follow the current visibility setting for connector.

ConnectorVisibilitySetting

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

The "Show Connectors" feature should register newly placed nodes

Reviewers

@DynamoDS/dynamo

FYIs

@emru-y

@QilongTang QilongTang added this to the 2.17.0 milestone Aug 3, 2022
@QilongTang QilongTang removed this from the 2.17.0 milestone Oct 28, 2022
@QilongTang QilongTang changed the title [WIP] Enable Default Connector Visibility on Recordable Command Level [Blocked] Enable Default Connector Visibility on Recordable Command Level Nov 8, 2022
@github-actions github-actions bot changed the title [Blocked] Enable Default Connector Visibility on Recordable Command Level DYN-5161: [Blocked] Enable Default Connector Visibility on Recordable Command Level Sep 16, 2024
github-actions[bot]
github-actions bot reviewed Sep 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-5161

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang changed the title DYN-5161: [Blocked] Enable Default Connector Visibility on Recordable Command Level DYN-5161 The "Show Connectors" feature should register newly placed nodes Sep 16, 2024
@QilongTang QilongTang added this to the 3.4 milestone Sep 16, 2024
@QilongTang QilongTang marked this pull request as ready for review September 16, 2024 17:44
@QilongTang QilongTang merged commit 8bef8e6 into master Sep 16, 2024
30 checks passed
@QilongTang QilongTang deleted the ConnectorDefaultVisibility branch September 16, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@zeusongit zeusongit zeusongit approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

@RobertGlobant20 RobertGlobant20 Awaiting requested review from RobertGlobant20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @zeusongit