Pinned Note on Dismissed Warnings #13128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pinned Note correctly aligns to the Node once a Warning is dismissed
- for internal review, Commit may be reverted later - attempts to allow Copy/Paste for Pins (ConnectorPinModel) - working directly inside the Copy() and Paste() methods of DynamoModel
This reverts commit 056a7c1.
reddyashish
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to rectify an issue where a pinned Note would remain in the same offset location after a Warning (dialog) has been dismissed. Normally, a Note would correctly get pushed up to provide space for the Warning tooltip dialog. However, when a Warning is dismissed, the space provided is no longer needed. This PR fixes this issue.
A secondary purpose of this PR is to make sure a Warning Dialog is always displayed on top, even in case of a more recent UI element (note). Currently, a note added after a Warning has been registered will appear on top of the Warning, which should not be the case. (Postponed)
A third potential goal is to allow to copy Connector Pins when copying/pasting Nodes with Pinned Connectors. (WIP)
Pin Dismissed Warnings
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@mjkkirschner
FYIs
@Amoursol