Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted locations edit path should work for subdirectories #13109

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jul 14, 2022

Purpose

Task: https://jira.autodesk.com/browse/DYN-5090

When a trusted path is edited to its subdirectory, it should update to the subdirectory path. Since the subdirectory was already considered a trusted location, it was not being updated previously.
For the add path button, a subdirectory of a trusted location should not be added as a new path as the parent directory is already added.

Updated the edit icons.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Trusted locations edit path should work for subdirectories.

Reviewers

@QilongTang @zeusongit

@reddyashish
Copy link
Contributor Author

@QilongTang
Copy link
Contributor

LGTM would you record gifs?

@QilongTang QilongTang added this to the 2.16.0 milestone Jul 14, 2022
@reddyashish
Copy link
Contributor Author

edit trusted locations

@reddyashish reddyashish merged commit a1eef6a into DynamoDS:master Jul 14, 2022
@QilongTang
Copy link
Contributor

I noticed that in this PR we did not delete the folder icon which is no longer used. Can you confirm and add a follow up PR deleting them?

@reddyashish reddyashish deleted the TrustedLocationsEditPath branch November 23, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants