Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize the Group Styles panel in Preferences window #13099

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jul 11, 2022

Purpose

Task: https://jira.autodesk.com/browse/DYN-5051

The max height is set for the scroll-viewer to make the grid height dynamic.

When only the default styles are present.
Screen Shot 2022-07-13 at 8 53 59 AM

When custom styles are also present.
Screen Shot 2022-07-13 at 8 53 44 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Resize the Group Styles panel in Preferences window

Reviewers

@QilongTang

@zeusongit
Copy link
Contributor

The task AC says to display 8 styles, was there a change?

@QilongTang
Copy link
Contributor

The task AC says to display 8 styles, was there a change?

That could be my mistake, I thought by default it was 6 styles. On the same note, @reddyashish do you think we can reduce the gap between styles to fully display 6 styles by default?

@reddyashish
Copy link
Contributor Author

reddyashish commented Jul 12, 2022

I set the maximize height such that the 2 other headers are still visible in the top page. I will see if we can remove any additional space in between.

@reddyashish
Copy link
Contributor Author

Updated the styling. We will now have 6 in the first screen without any scrollbar.

@QilongTang
Copy link
Contributor

LGTM @Amoursol What do you think?

@reddyashish
Copy link
Contributor Author

@QilongTang QilongTang added this to the 2.16.0 milestone Jul 13, 2022
@Amoursol
Copy link
Contributor

LGTM @Amoursol What do you think?

Looks good! Happy to see this merged.

@reddyashish reddyashish merged commit b0694a9 into DynamoDS:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants