Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guided tour crash #13097

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Fix guided tour crash #13097

merged 6 commits into from
Jul 11, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jul 11, 2022

Purpose

Fixes the crash in here : https://jira.autodesk.com/browse/DYN-5056

When a home workspace is closed, we will close the file trust dialog if it is open. This will prevent the guided tour crash and also enables the user to just close the workspace using the close button.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang @zeusongit

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a unit test somehow?

@reddyashish
Copy link
Contributor Author

Added a UI test.

@reddyashish
Copy link
Contributor Author

@reddyashish reddyashish merged commit bde665e into DynamoDS:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants