Workspace References refactoring #13078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
commented
Jun 30, 2022
| @@ -283,7 +287,6 @@ private void DownloadPackage(object sender, RoutedEventArgs e) | |||
| internal void DownloadSpecifiedPackageAndRefresh(PackageDependencyInfo info) | |||
| { | |||
| packageInstaller.DownloadAndInstallPackage(info); | |||
| DependencyRegen(currentWorkspace); | |||
There was a problem hiding this comment.
This is not needed as the DependencyRegen is being called after the package is loaded
QilongTang
reviewed
Jul 1, 2022
|
Thanks for the PR clarification, good stuff |
QilongTang
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to refactor some of the code related to workspace references view extension.
Task: https://jira.autodesk.com/browse/DYN-5028
In the current workflow, the workspace references are computed when a workspace is saved(to serialize the new data) and when the data needs to be updated on the view extension. To avoid doing it twice, a new flag is introduced that would control the workspace references computation. After this change, if the user clicks on "recalculate" button, the references would be computed only if the workspace has unsaved changes. On the other hand, if the user saves the workspace, the references are computed during serialization, saved in a list and that list is displayed in the view extension.
When a workspace is opened, we want to compute the references even though there are no saved changes. This can done by using the 'ForceComputeWorkspaceReferences' flag. The same is the case when the view extension is opened using the menu item or when a new package is loaded after downloading the missing package references.
Also cleaned up some of the related code.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Workspace References refactoring
Reviewers
@QilongTang @zeusongit @aparajit-pratap @mjkkirschner