Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Vertical Margin of Note in Group #13068

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jun 28, 2022

Purpose

A but-fix affecting Notes inside Groups. Notes display a consistent vertical offset, which has been addressed with this PR.

Before

before

After

after

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • fixed an issue where Notes in Groups display a skewed vertical margin causing the Note to overlap when in the top position or push the boundary unrealistically when in the bottom position inside the Group

Reviewers

@reddyashish
@mjkkirschner

FYIs

@Amoursol

- fixed an issue where Notes in Groups display a skewed vertical margin causing the Note to overlap when in top position or push the boundary unrealistically when in bottom position inside the Group
@reddyashish
Copy link
Contributor

Is there a task for this?

@Amoursol
Copy link
Contributor

Amoursol commented Jun 28, 2022

Is there a task for this?

In Jira it is: https://jira.autodesk.com/browse/DYN-4162 😊

@reddyashish
Copy link
Contributor

Looks good to me. I will run the self-serve before merging.

@reddyashish
Copy link
Contributor

@reddyashish reddyashish merged commit a81555e into DynamoDS:master Jul 1, 2022
@QilongTang QilongTang added this to the 2.16.0 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants