-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-4973-Popups-NotAttached #13002
DYN-4973-Popups-NotAttached #13002
Conversation
I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive (in background). I've tested the functionality for the User Interface tour and Packages tour and for the exitwindow that appear in the Packages tour. For the other tours the RealTimeWindow (that appear when exiting the Guide) wont' have this functionality implemented.
Does this also fix toast notifications, are they also attached to parent window now? |
@zeusongit
For the RealTimeInfo popup I think @QilongTang changed the StaysOpen property in a different PR then it should be closing the Popup when the focus is lost. |
I removed all the functionality of setting a state in the Guide and also added a new event for when the tour is completely closed (just in the case of the Packages guide).
Changed the hard-coded string to use the static string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, then LGTM
Event renamed from GuidedTourClosed to GuidedTourFinished. The property warningPopup was renamed to fileTrustWarningPopup.
Event renamed from GuidedTourFinished to GuidedTourExited
Fixing function name to match event name.
Removed subscriptions to GuidedTourExited event and the empty function handler.
Renaming property to IsGuideExited
After the changes done in the next PR: #13002 I introduced a bug that was not allowing to save the path added in trusted locations, then with this fix is saving again the trusted locations.
Purpose
I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive (in background).
I've tested the functionality for the User Interface tour and Packages tour and for the exitwindow that appear in the Packages tour.
For the other tours the RealTimeWindow (that appear when exiting the Guide) wont' have this functionality implemented.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive.
Reviewers
@QilongTang
FYIs