Update Run Status Message to Run Blocked during File Trust Warning #12953
Conversation
| @@ -20,8 +20,10 @@ public class RunSettings : NotificationObject | |||
| private RunType runType; | |||
| private bool runEnabled; | |||
| private bool runTypesEnabled; | |||
| private bool runTypesComboBoxToolTipIsEnabled; | |||
There was a problem hiding this comment.
It is not used for now
| { | ||
| HomeSpace.RunSettings.ForceAutomaticWithoutRun = true; |
There was a problem hiding this comment.
@RobertGlobant20 I included a minimal fix for now and plan to rethink about this boolean with you a bit to cover the periodic run mode as well
| if(!PreferenceSettings.TrustedLocations.Contains(directoryName) && DynamoModel.IsTestMode == false) | ||
| { | ||
| HomeSpace.RunSettings.ForceAutomaticWithoutRun = true; | ||
| bShowFileTrustWarning = true; |
There was a problem hiding this comment.
So we do not need to set bShowFileTrustWarning true anymore?
There was a problem hiding this comment.
This boolean can be skipped since it is a local one, after adjusting the order we no longer need it
| @@ -265,6 +265,12 @@ void hwm_EvaluationCompleted(object sender, EvaluationCompletedEventArgs e) | |||
| /// </summary> | |||
| internal void UpdateRunStatusMsgBasedOnStates() | |||
| { | |||
| if ((bool)((Model as HomeWorkspaceModel)?.RunSettings.ForceAutomaticWithoutRun)) | |||
There was a problem hiding this comment.
won't this cast fail if Model is a customWorkspaceModel? Or will null cast to false?
There was a problem hiding this comment.
@mjkkirschner I did confirm that this function is bind to graph evaluation so the above case would not happen
|
@RobertGlobant20 @zeusongit I am going to merge this so the code is synced between us when we work on all following improvements |
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Per https://jira.autodesk.com/browse/DYN-4998, update run status message.
After:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Update Run Status Message to Run Blocked during File Trust Warning
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of