-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Identifiers in preview bubble and watch node. #12950
Conversation
Fixing the regressions |
All tests passing now. |
Taking a look now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments then LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @zeusongit what do you think?
@QilongTang - @reddyashish - just a thought, have you considered using a feature flag to control this feature in case there are performance issues with large data sets? Then we could disable it after release or after longer testing cycle. |
@mjkkirschner Simulated the watch node with large lists and did not notice any difference. Do you mind if I add that in a followup task once we test it in bug-bash? |
Created a spike to investigate other cases for any performance drop. https://jira.autodesk.com/browse/DYN-5010 |
Purpose
This PR is to implement type identifiers for the data in preview bubble and watch node.
Task: https://jira.autodesk.com/browse/DYN-3416
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Type Identifiers in preview bubble and watch node.
Reviewers
@QilongTang @zeusongit