Fix Publish package remove item bug #12941
Conversation
|
@zeusongit So this is not a new regression? |
No, apparently this used to happen before as well, I guess somehow was never discovered. |
| string fileName = packageItemRootViewModel.FileInfo == null ? packageItemRootViewModel.Name : packageItemRootViewModel.FileInfo.FullName; | ||
| string fileType = packageItemRootViewModel.DependencyType.ToString(); | ||
|
|
||
| if (fileName.ToLower().EndsWith(".dll") || fileType.Equals(DependencyType.Assembly)) |
There was a problem hiding this comment.
If the filetype is DependencyType.Assembly, I suppose it should be a dll. Do we need both the checks?
There was a problem hiding this comment.
Yes, this was the case before, but I noticed that we do not get filename with .dll extension, therefore added another check that will satisfy this condition, putting an && will not pass if the filename is without extension.
There was a problem hiding this comment.
what about packages that ship .exes? I'm not sure if that was allowed before, but if it was this might be a breaking change?
ahh, did not see the ||
There was a problem hiding this comment.
According to the current flow, they will end up in additional files
There was a problem hiding this comment.
Do you want me to add .exe extension to assemblies?
There was a problem hiding this comment.
Do exes have Dependency Type as Assembly?
There was a problem hiding this comment.
I think not - according to:
Dynamo/src/DynamoPackages/Package.cs
Line 335 in 74709f7
we only scan files ending in *.dll and assign those types as assembly. I guess like you said above .exes would just be another file in extra.
I don't think theres any reason to change that now, just wanted to avoid making any inadvertent changes near to release.
There was a problem hiding this comment.
I published a test package with exes, it ends up in additional files, so we are good.
thanks for the review @reddyashish @mjkkirschner
* update remove item * cvb
Purpose
Fix a bug in Dynamo Publish Package window, where user was unable to remove an item after publishing it it the next version. The problem was that the PackageContent list was being refreshed, bringing all the concatenated files back, including the deleted ones, therefore now we are updating each separate file list as well, so that a PackageContent refresh won't affect the delete action.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of