Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note Pin/Unpin Redo #12913

Closed
wants to merge 1 commit into from
Closed

Note Pin/Unpin Redo #12913

wants to merge 1 commit into from

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 23, 2022

Purpose

This is a minor Bug fix. The ability to Redo after a Note has been Pinned to a Node and Undo is triggered.

redo-pin-note

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • ModelBase.cs - Redo added to SaveContext enum
  • NodeModel.cs - new Action RedoRequest that is triggered on Redo
  • NoteViewModel.cs - new RePintoNode method that contains the logic for dealing with Redo

Reviewers

@reddyashish

FYIs

@mjkkirschner
@Amoursol

@dnenov
Note Pin/Unpin Redo
c02f8e5 
- additional functionality to support the ability to Redo pinning/unpinning a note to node
@mjkkirschner
Copy link
Member

mjkkirschner commented May 23, 2022 •
edited
Loading

there are 67 test failures here -

All Failed Tests

Test Name Duration Age
DynamoCoreWpfTests.AnnotationViewModelTests.UndoMovingNoteInsideGroup 0.11 sec 1
Dynamo.Tests.ComplexTests.Combine 0.42 sec 1
Dynamo.Tests.ComplexTests.Count 0.22 sec 1
Dynamo.Tests.ComplexTests.CreateList 0.25 sec 1
Dynamo.Tests.ComplexTests.Flatten 0.22 sec 1
Dynamo.Tests.ComplexTests.ListLacing 0.3 sec 1
Dynamo.Tests.ComplexTests.Math 0.63 sec 1
Dynamo.Tests.ComplexTests.PassingFunctions 0.29 sec 1
Dynamo.Tests.ComplexTests.RangeSyntax 0.31 sec 1
Dynamo.Tests.ComplexTests.ReadFromCSV 0.36 sec 1
Dynamo.Tests.ComplexTests.Test_Basket1 0.3 sec 1
Dynamo.Tests.ComplexTests.Test_Basket3 0.32 sec 1
Dynamo.Tests.ComplexTests.Test_buckyballInCodeBlock 0.35 sec 1
Dynamo.Tests.ComplexTests.Test_CodeBlocksReference 0.34 sec 1
Dynamo.Tests.ComplexTests.Test_Core_Python 0.23 sec 1
Dynamo.Tests.ComplexTests.Test_Lacing 0.22 sec 1
Dynamo.Tests.ComplexTests.Test_MinMax 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_Mobius 0.28 sec 1
Dynamo.Tests.ComplexTests.Test_PassingFunctions 0.38 sec 1
Dynamo.Tests.ComplexTests.Test_Reverse 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_Sort 0.27 sec 1
Dynamo.Tests.ComplexTests.Test_SortGeometry 0.31 sec 1
Dynamo.Tests.ComplexTests.Test_Transpose 0.24 sec 1
Dynamo.Tests.ComplexTests.Test_Vignette_01Plane_Offset 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_Vignette_01WireFrame_Section 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_WorkFlowTestForCSV 0.38 sec 1
DynamoCoreWpfTests.ConnectorViewModelTests.ConnectorVisibilityForLegacyXMLGraphTest 1.8 sec 1
Dynamo.Tests.DSEvaluationModelTest.Regress9279_NoRandomNull 0.25 sec 1
Dynamo.Tests.DSEvaluationModelTest.Test_IfOutputFunctionObject_3483 0.34 sec 1
Dynamo.Tests.DynamoDefects.Defect_MAGN_3998 0.33 sec 1
Dynamo.Tests.DynamoDefects.Defect_MAGN_847 0.3 sec 1
Dynamo.Tests.GeometryDefectTests.MAGN_4924_CurveExtractionFromSurface 0.32 sec 1
Dynamo.Tests.GeometryDefectTests.MAGN_5041_NurbsCurveExtend 0.32 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutConnectedGroups 0.38 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutGroupedNotes 0.33 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutTree 0.42 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutTreeSelection 0.37 sec 1
Dynamo.Tests.NodeExecutionTest.LoadGraphWithFreezeNodes_Defect9274 0.22 sec 1
Dynamo.Tests.NodeToCodeTest.TestBasicNode2CodeWorkFlow3 0.35 sec 1
Dynamo.Tests.NodeToCodeTest.TestBasicNode2CodeWorkFlow4 0.28 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.AreaFromStringHasTextBoxWithCorrectValue 10 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.BoolSelectorHasRadioButtonsAndProperlySetValues 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.CustomNodeIsCustomized 0.75 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.DirectoryHasButton 0.87 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.DoubleInputHasTextBoxAndCorrectValue 0.89 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.DoubleSliderHasSliderAndCorrectValues 0.76 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.FilenameHasButton 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.IntegerSliderHasSliderAndCorrectValues 0.76 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.LengthFromStringHasTextBoxWithCorrectValue 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.PythonNodeHasButtonsAndCorrectNumberOfInputs 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.PythonStringNodeHasButtonsAndCorrectNumberOfInputs 0.87 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.StringInputHasTextboxAndCorrectValue 0.78 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.VolumeFromStringHasTextBoxWithCorrectValue 0.73 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.Watch3DHasViewer 0.77 sec 1
DynamoCoreWpfTests.NodeViewTests.InputPortType_NodeModelNode_AreCorrect 1 sec 1
DynamoCoreWpfTests.NodeViewTests.ZIndex_NodeAsMemberOfGroup 0.8 sec 1
DynamoCoreWpfTests.NodeViewTests.ZIndex_Test_MouseDown 0.8 sec 1
DynamoCoreWpfTests.NodeViewTests.ZIndex_Test_MouseEnter_Leave 0.93 sec 1
DynamoCoreWpfTests.NoteViewTests.CanPinNodeToNode 9.2 sec 1
DynamoCoreWpfTests.NoteViewTests.CanSelectPinnedNodeThroughNote 0.75 sec 1
DynamoCoreWpfTests.NoteViewTests.NoteIsPlacedAbovePinnedNode 0.7 sec 1
DynamoCoreWpfTests.NoteViewTests.NoteIsPlacedAbovePinnedNodeInErrorState 0.74 sec 1
DynamoCoreWpfTests.NoteViewTests.T01_ZIndex_Test_MouseDown 0.69 sec 1
DynamoCoreWpfTests.NoteViewTests.T02_ZIndex_Test_NoteGreaterThanNode 0.71 sec 1
DynamoCoreWpfTests.NoteViewTests.T03_Mousedown_NoteGreaterThanNode 0.72 sec 1
DynamoCoreWpfTests.NoteViewTests.UndoPinNode 0.71 sec 1
Dynamo.Tests.PackageValidationTest.TestLoadPackageFromOtherLocation

All Failed Tests
Test Name
Duration
Age
DynamoCoreWpfTests.AnnotationViewModelTests.UndoMovingNoteInsideGroup 0.11 sec 1
Dynamo.Tests.ComplexTests.Combine 0.42 sec 1
Dynamo.Tests.ComplexTests.Count 0.22 sec 1
Dynamo.Tests.ComplexTests.CreateList 0.25 sec 1
Dynamo.Tests.ComplexTests.Flatten 0.22 sec 1
Dynamo.Tests.ComplexTests.ListLacing 0.3 sec 1
Dynamo.Tests.ComplexTests.Math 0.63 sec 1
Dynamo.Tests.ComplexTests.PassingFunctions 0.29 sec 1
Dynamo.Tests.ComplexTests.RangeSyntax 0.31 sec 1
Dynamo.Tests.ComplexTests.ReadFromCSV 0.36 sec 1
Dynamo.Tests.ComplexTests.Test_Basket1 0.3 sec 1
Dynamo.Tests.ComplexTests.Test_Basket3 0.32 sec 1
Dynamo.Tests.ComplexTests.Test_buckyballInCodeBlock 0.35 sec 1
Dynamo.Tests.ComplexTests.Test_CodeBlocksReference 0.34 sec 1
Dynamo.Tests.ComplexTests.Test_Core_Python 0.23 sec 1
Dynamo.Tests.ComplexTests.Test_Lacing 0.22 sec 1
Dynamo.Tests.ComplexTests.Test_MinMax 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_Mobius 0.28 sec 1
Dynamo.Tests.ComplexTests.Test_PassingFunctions 0.38 sec 1
Dynamo.Tests.ComplexTests.Test_Reverse 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_Sort 0.27 sec 1
Dynamo.Tests.ComplexTests.Test_SortGeometry 0.31 sec 1
Dynamo.Tests.ComplexTests.Test_Transpose 0.24 sec 1
Dynamo.Tests.ComplexTests.Test_Vignette_01Plane_Offset 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_Vignette_01WireFrame_Section 0.29 sec 1
Dynamo.Tests.ComplexTests.Test_WorkFlowTestForCSV 0.38 sec 1
DynamoCoreWpfTests.ConnectorViewModelTests.ConnectorVisibilityForLegacyXMLGraphTest 1.8 sec 1
Dynamo.Tests.DSEvaluationModelTest.Regress9279_NoRandomNull 0.25 sec 1
Dynamo.Tests.DSEvaluationModelTest.Test_IfOutputFunctionObject_3483 0.34 sec 1
Dynamo.Tests.DynamoDefects.Defect_MAGN_3998 0.33 sec 1
Dynamo.Tests.DynamoDefects.Defect_MAGN_847 0.3 sec 1
Dynamo.Tests.GeometryDefectTests.MAGN_4924_CurveExtractionFromSurface 0.32 sec 1
Dynamo.Tests.GeometryDefectTests.MAGN_5041_NurbsCurveExtend 0.32 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutConnectedGroups 0.38 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutGroupedNotes 0.33 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutTree 0.42 sec 1
Dynamo.Tests.GraphLayoutTests.GraphLayoutTreeSelection 0.37 sec 1
Dynamo.Tests.NodeExecutionTest.LoadGraphWithFreezeNodes_Defect9274 0.22 sec 1
Dynamo.Tests.NodeToCodeTest.TestBasicNode2CodeWorkFlow3 0.35 sec 1
Dynamo.Tests.NodeToCodeTest.TestBasicNode2CodeWorkFlow4 0.28 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.AreaFromStringHasTextBoxWithCorrectValue 10 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.BoolSelectorHasRadioButtonsAndProperlySetValues 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.CustomNodeIsCustomized 0.75 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.DirectoryHasButton 0.87 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.DoubleInputHasTextBoxAndCorrectValue 0.89 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.DoubleSliderHasSliderAndCorrectValues 0.76 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.FilenameHasButton 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.IntegerSliderHasSliderAndCorrectValues 0.76 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.LengthFromStringHasTextBoxWithCorrectValue 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.PythonNodeHasButtonsAndCorrectNumberOfInputs 0.77 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.PythonStringNodeHasButtonsAndCorrectNumberOfInputs 0.87 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.StringInputHasTextboxAndCorrectValue 0.78 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.VolumeFromStringHasTextBoxWithCorrectValue 0.73 sec 1
DynamoCoreWpfTests.NodeViewCustomizationTests.Watch3DHasViewer 0.77 sec 1
DynamoCoreWpfTests.NodeViewTests.InputPortType_NodeModelNode_AreCorrect 1 sec 1
DynamoCoreWpfTests.NodeViewTests.ZIndex_NodeAsMemberOfGroup 0.8 sec 1
DynamoCoreWpfTests.NodeViewTests.ZIndex_Test_MouseDown 0.8 sec 1
DynamoCoreWpfTests.NodeViewTests.ZIndex_Test_MouseEnter_Leave 0.93 sec 1
DynamoCoreWpfTests.NoteViewTests.CanPinNodeToNode 9.2 sec 1
DynamoCoreWpfTests.NoteViewTests.CanSelectPinnedNodeThroughNote 0.75 sec 1
DynamoCoreWpfTests.NoteViewTests.NoteIsPlacedAbovePinnedNode 0.7 sec 1
DynamoCoreWpfTests.NoteViewTests.NoteIsPlacedAbovePinnedNodeInErrorState 0.74 sec 1
DynamoCoreWpfTests.NoteViewTests.T01_ZIndex_Test_MouseDown 0.69 sec 1
DynamoCoreWpfTests.NoteViewTests.T02_ZIndex_Test_NoteGreaterThanNode 0.71 sec 1
DynamoCoreWpfTests.NoteViewTests.T03_Mousedown_NoteGreaterThanNode 0.72 sec 1
DynamoCoreWpfTests.NoteViewTests.UndoPinNode 0.71 sec 1
Dynamo.Tests.PackageValidationTest.TestLoadPackageFromOtherLocation

@dnenov
Copy link
Collaborator Author

dnenov commented May 24, 2022

Hi @mjkkirschner - thanks for flagging these up. I wanted to push this PR so we can have a discussion with Ashish as there are a few things I want him to review.

With that in mind, I don't know if these are not failing on the master as well at the moment? I just ran some of the tests against master and they are failing with no code changes on my side.

In any case, I will be meeting with @reddyashish shortly and will bring these up! Thanks again for letting me know.

@dnenov
Copy link
Collaborator Author

dnenov commented May 25, 2022

Closing this PR, a new PR for the same issue was opened here

@dnenov dnenov closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnenov @mjkkirschner